Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heatmaps don't work with PolarAxis in GLMakie #4190

Open
ffreyer opened this issue Aug 22, 2024 · 4 comments
Open

heatmaps don't work with PolarAxis in GLMakie #4190

ffreyer opened this issue Aug 22, 2024 · 4 comments
Labels
bug GLMakie This relates to GLMakie.jl, the OpenGL backend for Makie. heatmap & image PolarAxis transformation related to `Transformation` objects

Comments

@ffreyer
Copy link
Collaborator

ffreyer commented Aug 22, 2024

  • what version of Makie are you running? 0.21.7 master
  • can you reproduce the bug with a fresh environment ? yes
  • What platform + GPU are you on? irrelevant

This doesn't show any plot for me in GLMakie, but does in CairoMakie and WGLMakie:

fig = Figure()
ax = PolarAxis(fig[1, 1])
heatmap!(ax, rand(10, 10))
fig

Possibly caused by #4125 not catching the transform func from PolarAxis as a reason to not use image

@ffreyer ffreyer added GLMakie This relates to GLMakie.jl, the OpenGL backend for Makie. regression This issue describes a regression from a previous version or commit. labels Aug 22, 2024
@SimonDanisch
Copy link
Member

image
This is expected, since we don't use 2d transforms in heatmap for GLMakie, but rather transform x and y separately.

@ffreyer
Copy link
Collaborator Author

ffreyer commented Aug 27, 2024

I opened this in relation to some other issue, should've posted which... Maybe #742, as curvelinear heatmaps could be done with transforms like Polar if that pipeline works.

@SimonDanisch
Copy link
Member

I'd say its a duplicate of that issue, is it?

@ffreyer ffreyer added bug and removed regression This issue describes a regression from a previous version or commit. labels Aug 27, 2024
@ffreyer ffreyer changed the title heatmaps no longer work with PolarAxis in GLMakie heatmaps don't work with PolarAxis in GLMakie Aug 27, 2024
@ffreyer
Copy link
Collaborator Author

ffreyer commented Aug 27, 2024

Hmm, maybe this wasn't a regression. But I still think it would be good to fix for feature parity between backends.

@ffreyer ffreyer added transformation related to `Transformation` objects heatmap & image labels Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug GLMakie This relates to GLMakie.jl, the OpenGL backend for Makie. heatmap & image PolarAxis transformation related to `Transformation` objects
Projects
None yet
Development

No branches or pull requests

2 participants