Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axis3 causes markers of a meshscatter to be transformed #3323

Open
ffreyer opened this issue Oct 29, 2023 · 0 comments · Fixed by #4606
Open

Axis3 causes markers of a meshscatter to be transformed #3323

ffreyer opened this issue Oct 29, 2023 · 0 comments · Fixed by #4606
Labels
Axis3 related to Axis3 enhancement Feature requests and enhancements Makie Backend independent issues (Makie core) transformation related to `Transformation` objects

Comments

@ffreyer
Copy link
Collaborator

ffreyer commented Oct 29, 2023

On master, beta-20 (pre lighting merge, #3113), lighting (#3246) (In GLMakie, but this should be the same across backends)

fig = Figure()
a = Axis3(fig[1, 1])
ps = decompose(Point3f, Sphere(Point3f(0), 1f0), 10)
arrows!(a, map(p -> Point3f(10, 10, 1) .* p .+ Point3f(0), ps), Vec3f.(ps))
fig

Screenshot from 2023-10-29 14-40-32

This is happening because the scaling factor derived from the positional argument is applied to the vertices of the scattered mesh as well.

To fix this, we should probably add a transform_marker attribute to meshscatter and adjust Axis3 to not normalize to a unit box (in terms of internal coordinates, not visuals). I tried this a bit in the lighting pr but ran into issues with near/far. I'll try to look into this again after we get done with v0.20.

@ffreyer ffreyer added the bug label Oct 29, 2023
@ffreyer ffreyer added enhancement Feature requests and enhancements transformation related to `Transformation` objects Axis3 related to Axis3 Makie Backend independent issues (Makie core) and removed bug labels Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Axis3 related to Axis3 enhancement Feature requests and enhancements Makie Backend independent issues (Makie core) transformation related to `Transformation` objects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant