Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non-zero exit code when problems are found #51

Merged
merged 1 commit into from
Aug 27, 2019
Merged

Use non-zero exit code when problems are found #51

merged 1 commit into from
Aug 27, 2019

Conversation

jfelchner
Copy link

@jfelchner jfelchner commented Jul 26, 2019

Adds a return value from run which is the appropriate exit code based on the result of the run.

We then set process.exitCode to that value and the CLI will exit with that value when the script completes.

Tests were also modified to expect the correct return value.

Closes #7

@Duder-onomy
Copy link
Contributor

@Turbo87 Can this be merged? Looking to add this in my CI workflow.

Copy link
Collaborator

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! 👍

@Turbo87 Turbo87 changed the title Add: Process Exit Code If Errors Are Found Use non-zero exit code when problems are found Aug 27, 2019
@Turbo87 Turbo87 added breaking enhancement New feature or request labels Aug 27, 2019
@Turbo87 Turbo87 merged commit 5d1e863 into mainmatter:master Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use non-zero exit code when problems are found
3 participants