Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge ActiveNotification and PendingNotificationRequest? #2494

Open
Levi-Lesches opened this issue Dec 13, 2024 · 0 comments
Open

Merge ActiveNotification and PendingNotificationRequest? #2494

Levi-Lesches opened this issue Dec 13, 2024 · 0 comments

Comments

@Levi-Lesches
Copy link
Contributor

Levi-Lesches commented Dec 13, 2024

Active notifications have all the fields pending notifications do, plus more optional/nullable ones, so these can naturally be combined into one class, something like PlatformNotification. With typedefs, this change would be invisible to end users and would reduce some code duplication across platforms.

I'd have to check into it more, but it seems this would also allow pending notifications to return more data. Eg, on Android, we control what data is saved via SharedPreferences, so it would be trivial to save more notificationDetails fields

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant