Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why lowercasing everything? #17

Open
MorenoLaQuatra opened this issue Jun 27, 2022 · 3 comments
Open

Why lowercasing everything? #17

MorenoLaQuatra opened this issue Jun 27, 2022 · 3 comments
Labels

Comments

@MorenoLaQuatra
Copy link

Hi,

First of all thanks for the contribution to the community!

Perhaps a silly question, is there any specific reason why the title, abstract, and authors are all lowercased by the library?

@Mahdisadjadi
Copy link
Owner

Hi @MorenoLaQuatra and thank you!

Not really, during the tests I noticed API returns the name with all kinds of formats so decided to normalize it. Do you have a use case that requires the original string?

@MorenoLaQuatra
Copy link
Author

I was just using the library for scraping some articles from arxiv, but I think the API changed a little since your implementation.
Given the extensive modifications required for my use case, I just created a new repo that is updated according to my needs. If you agree with that I provided you the credits for the original implementation https://github.com/MorenoLaQuatra/arxiv_search.

@Mahdisadjadi
Copy link
Owner

Thank you @MorenoLaQuatra for the credit. I like the modifications you've done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants