Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ledger - adapted data2 address #433

Open
Danie0918 opened this issue Nov 27, 2024 · 1 comment
Open

Ledger - adapted data2 address #433

Danie0918 opened this issue Nov 27, 2024 · 1 comment
Assignees
@homura
Labels
enhancement New feature or request

Comments

@Danie0918
Copy link
Contributor

Currently, all address types are displayed as Type, which needs to be optimized.
@Danie0918 Danie0918 added the enhancement New feature or request label Nov 27, 2024
@Danie0918 Danie0918 moved this to 🏗 In Progress in Neuron Nov 27, 2024
@Danie0918 Danie0918 added this to Neuron Nov 27, 2024
@Keith-CY
Copy link
Member

The current CKB app on Ledger device is based on the assumption that all addresses are in the form of lock_script.hash_type set to type, while ignoring the forms where lock_script.hash_type is data | data1 | data2. This results in addresses of the latter types being displayed incorrectly.

We need to fix the app and publish it to Ledger Live App Market.

@homura homura mentioned this issue Nov 27, 2024
Merged
@github-actions github-actions bot mentioned this issue Nov 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@homura homura

Labels
enhancement New feature or request
Projects
Neuron
Status: 🏗 In Progress
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Keith-CY @homura @Danie0918