Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displaying DAO rewards when deposited into NervosDAO #317

Closed
Danie0918 opened this issue Nov 13, 2023 · 6 comments
Closed

Displaying DAO rewards when deposited into NervosDAO #317

Danie0918 opened this issue Nov 13, 2023 · 6 comments
Assignees

Comments

@Danie0918
Copy link
Contributor

Danie0918 commented Nov 13, 2023

Original requirement:Magickbase/ckb-explorer-public-issues#462

PRD:https://vs0cjf.axshare.com/?id=vsq6ym&g=1&p=_462_show_dao_rewards

In Neuron, when opening Nervos DAO/Deposit, the pop-up will include the following new fields:

  • Estimated Rewards of 30 days: Estimated rewards for a 30-day deposit.

  • Estimated Rewards of 360 days: Estimated rewards for a 360-day deposit.

  • Estimated APC: Estimated Annual Percentage Compensation.

@Danie0918 Danie0918 added this to Neuron Nov 13, 2023
@Danie0918 Danie0918 moved this to 📌Planning in Neuron Nov 13, 2023
@Danie0918 Danie0918 self-assigned this Nov 13, 2023
@Danie0918 Danie0918 moved this from 📌Planning to 🎨 Designing in Neuron Jan 2, 2024
@Danie0918
Copy link
Contributor Author

【Displaying DAO rewards when deposited into NervosDAO】

  • Requirement Description: It's helpful to show rewards when depositing DAOs in Neuron.

Image

  • Requirement Contents
  1. Adjust the 'Don't reserve any CKBytes' option and make it only show at maximum value.
  2. Tips are not in constant manifestation and are included in the question mark icon. On mouseover of the question mark, the tips are displayed and an RFC hyperlink is provided.
  3. When the amount is entered the rewards are calculated and displayed.
  4. 'Estimated APC' adds a prompt message.

@Keith-CY
Copy link
Member

Keith-CY commented Jan 2, 2024

Adjust the 'Don't reserve any CKBytes' option and make it only show at maximum value.

Technically, it's hard to know the maximum value because the transaction fee is dynamic(due to dynamic fee rate and flexible transaction size), so the option may appear when the transaction cannot be constructed unless all cells are deposited.

@Danie0918
Copy link
Contributor Author

Danie0918 commented Jan 2, 2024

Adjust the 'Don't reserve any CKBytes' option and make it only show at maximum value.

Technically, it's hard to know the maximum value because the transaction fee is dynamic(due to dynamic fee rate and flexible transaction size), so the option may appear when the transaction cannot be constructed unless all cells are deposited.

The expectation is judged based on the progress bar max, which was optimized in a previous issue.

@Keith-CY
Copy link
Member

Keith-CY commented Jan 7, 2024

Adjust the 'Don't reserve any CKBytes' option and make it only show at maximum value.

Technically, it's hard to know the maximum value because the transaction fee is dynamic(due to dynamic fee rate and flexible transaction size), so the option may appear when the transaction cannot be constructed unless all cells are deposited.

The expectation is judged based on the progress bar max, which was optimized in a previous issue.

Then it looks good to me

@Danie0918 Danie0918 mentioned this issue Jan 18, 2024
@Danie0918 Danie0918 moved this from 🎨 Designing to 🏗 In Progress in Neuron Jan 19, 2024
@Danie0918 Danie0918 moved this from 🏗 In Progress to 🎨 Designing in Neuron Jan 25, 2024
@Danie0918 Danie0918 moved this from 🎨 Designing to 🏗 In Progress in Neuron Feb 26, 2024
@Danie0918
Copy link
Contributor Author

PR:nervosnetwork/neuron#3054

@Danie0918 Danie0918 moved this from 🏗 In Progress to 🔎 Code Review in Neuron Mar 4, 2024
@Danie0918 Danie0918 assigned silySuper and unassigned devchenyan Mar 15, 2024
@Danie0918 Danie0918 moved this from 🔎 Code Review to 👀 Testing in Neuron Mar 15, 2024
@Danie0918 Danie0918 moved this from 👀 Testing to ✅ Done in Neuron Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

6 participants