Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some issues of regression in light client mode #293

Closed
silySuper opened this issue Oct 7, 2023 · 13 comments
Closed

Some issues of regression in light client mode #293

silySuper opened this issue Oct 7, 2023 · 13 comments
Assignees
Labels
bug Something isn't working

Comments

@silySuper
Copy link

silySuper commented Oct 7, 2023

1.In Nervos Dao page ,sync process mainly affect 2 parts data : one is Locked data ,the other one is compensation cycle ends days.These 2 parts sometimes shows normally, then shows NaN or -- when is syncing.IMO,syncing process can not affect history data in expect,but actually it affects history data.

2023-10-07.10.04.03.mov
截屏2023-10-07 10 12 09

2.After clicking clear all synchronized data,the molecule can not change for a long time ,more than 20 minutes at the time when I have submited this issue.I have tried to quit this app and open again ,but not affect.
截屏2023-10-07 10 26 13
After quiting this app and open again:
截屏2023-10-07 10 40 58

@silySuper silySuper changed the title Some issues of Some issues of regression in light node mode Oct 7, 2023
@silySuper silySuper changed the title Some issues of regression in light node mode Some issues of regression in light client mode Oct 7, 2023
@silySuper silySuper added the bug Something isn't working label Oct 7, 2023
@silySuper silySuper added this to Neuron Oct 7, 2023
@silySuper silySuper moved this to 🆕 New in Neuron Oct 7, 2023
@silySuper
Copy link
Author

silySuper commented Oct 7, 2023

The second problem is still stay for about one hour ,how to make it syncing?

@yanguoyu
Copy link

yanguoyu commented Oct 7, 2023

Could you upload the debug information? Otherwise, I can not exactly get what happened to your Neuron.

@silySuper
Copy link
Author

neuron_debug_1696649152180.zip

This is the debug zip,and at this time it still stay the same.

@yanguoyu
Copy link

yanguoyu commented Oct 7, 2023

These 2 parts sometimes shows normally, then shows NaN or -- when is syncing

We can call rpc to ensure that light client rpc is running and get_tip_header call success:

curl http://localhost:9000/ -X POST -H "Content-Type: application/json" -d '{"jsonrpc": "2.0", "method": "get_tip_header", "params": [], "id": 1}'

That number is based on the current epoch, if get_tip_header calls fail, it may show NaN.

@silySuper
Copy link
Author

3.I have send a locktime transaction ,transaction hash is 0x39189b76094e69940312743daf1765e2890ae241a53f4b830dfc2eb63872f7b8,which block number is 10869532.But I cannot see this in customized assets when sync block is 10872475
截屏2023-10-07 16 26 56

截屏2023-10-07 16 27 07 截屏2023-10-07 16 26 21

@Danie0918 Danie0918 moved this from 🆕 New to 👀 Testing in Neuron Oct 7, 2023
@silySuper
Copy link
Author

3.I have send a locktime transaction ,transaction hash is 0x39189b76094e69940312743daf1765e2890ae241a53f4b830dfc2eb63872f7b8,which block number is 10869532.But I cannot see this in customized assets when sync block is 10872475 截屏2023-10-07 16 26 56

截屏2023-10-07 16 27 07 截屏2023-10-07 16 26 21

Actual result:
In light client mode:
same wallet locktime transaction send: before clear cache show ,after clear cache not show
different wallet locktime transaction send(receive wallet):before clear cache show ,after clear cache not show

In full client mode:
same wallet locktime transaction send: before clear cache show ,after clear cache not show
different wallet locktime transaction send(receive wallet):before clear cache show ,after clear cache not show

They are same result,not show difference.
截屏2023-10-08 09 32 53

@silySuper
Copy link
Author

These 2 parts sometimes shows normally, then shows NaN or -- when is syncing

We can call rpc to ensure that light client rpc is running and get_tip_header call success:

curl http://localhost:9000/ -X POST -H "Content-Type: application/json" -d '{"jsonrpc": "2.0", "method": "get_tip_header", "params": [], "id": 1}'

That number is based on the current epoch, if get_tip_header calls fail, it may show NaN.

I have select from get_tip_header method ,and found that sync schedule always slower then current schedule,some data of these two parts show NaN like this.Why not all data in these two parts show NaN?Maybe it may confuse user.
截屏2023-10-08 09 46 59

@yanguoyu
Copy link

yanguoyu commented Oct 8, 2023

3.I have send a locktime transaction ,transaction hash is 0x39189b76094e69940312743daf1765e2890ae241a53f4b830dfc2eb63872f7b8,which block number is 10869532.But I cannot see this in customized assets when sync block is 10872475 截屏2023-10-07 16 26 56

截屏2023-10-07 16 27 07 截屏2023-10-07 16 26 21

Fixed by nervosnetwork/neuron#2860

@silySuper
Copy link
Author

These 2 parts sometimes shows normally, then shows NaN or -- when is syncing

We can call rpc to ensure that light client rpc is running and get_tip_header call success:

curl http://localhost:9000/ -X POST -H "Content-Type: application/json" -d '{"jsonrpc": "2.0", "method": "get_tip_header", "params": [], "id": 1}'

That number is based on the current epoch, if get_tip_header calls fail, it may show NaN.

I have select from get_tip_header method ,and found that sync schedule always slower then current schedule,some data of these two parts show NaN like this.Why not all data in these two parts show NaN?Maybe it may confuse user. 截屏2023-10-08 09 46 59

Link issue:#294

@silySuper
Copy link
Author

silySuper commented Oct 8, 2023

4.In Asset Accounts/Send,when click full screen /not full screen,the style shows abnormal.

截屏2023-10-08 15 18 10 截屏2023-10-08 15 10 53

@silySuper
Copy link
Author

5.when window is smallest ,sign or verify message window lost sign button

截屏2023-10-08 16 22 45

6.when window is smallest ,multisig address window shows abnormal.
截屏2023-10-08 16 02 34

@yanguoyu
Copy link

yanguoyu commented Oct 8, 2023

@silySuper

4.In Asset Accounts/Send,when click full screen /not full screen,the style shows abnormal.
5.when window is smallest ,sign or verify message window lost sign button

They are fixed by nervosnetwork/neuron#2860

@Danie0918 Danie0918 assigned silySuper and unassigned yanguoyu and Danie0918 Oct 9, 2023
@silySuper
Copy link
Author

1.No.1 and No.3 will be optimized in later versions,others has been verified.

@Danie0918 Danie0918 moved this from 👀 Testing to 🚩Pre Release in Neuron Oct 9, 2023
@Keith-CY Keith-CY moved this from 🚩Pre Release to ✅ Done in Neuron Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants