-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an action to update assumed valid target periodically #211
Comments
|
IMG, the rc-branch should be fully tested for a week, so the
Does it mean trigger an action run when the PR from rc/* to main is opened
Personally a JavaScript script is preferred because it's easy for reviewers and maintainers, and JavaScript is supported in GitHub runner with https://github.com/actions/github-script |
yes, but I believe the trigger event can be set as
Javascript is also no problem, I will wrap the process into a npm command. Then we only need to |
Triggered by |
https://github.com/technote-space/create-pr-action not support
I have found some action plugins to add and commit, but because of actions/runner#667
Cause of we currently only update one file, I would prefer the first resolution. |
The timing to update |
How about when trigger on the create event or the push event on the |
It should work to trigger this workflow when |
The
CKB_NODE_ASSUME_VALID_TARGET
defined at https://github.com/nervosnetwork/neuron/blob/develop/packages/neuron-wallet/.env#L120 is used on launching the built-in CKB node to boost performance.It's expected to be at least 7 days before the release day and was updated manually. It introduced a mental burden in the release workflow, so it's expected to be updated automatically by the CI.
The following work will be done:
rc/*
tomaster,
and the update should open a new PR to therc/*
It may take a long time to merge
rc/*
intomaster
so thatassumed valid target
is more than 7 days before the release day, but it's acceptable IMO.Or the script could be run on merge from
rc/*
tomaster
and the commit is adopted on themain
while the script sets 7 days before rather than 1 day before.The text was updated successfully, but these errors were encountered: