-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename the built-in CKB node #200
Comments
|
We should ignore the network |
The |
When checking whether the user has changed the default node, we will ignore |
Yes, |
Currently there is no restriction on linking users to external nodes here, need to add restrictions like light client nodes. |
To inform users about this update, a dialog could be displayed when the |
To be more specific:
|
Will be fixed in #284 |
default node
was used to denote the internal ckb node before. There're 2 problems:default node
is not classical, typically it should be capitalized asDefault Node
default node
is not exactly what it represents, it was meant to be the built-in ckb node. But now, thedefault node
can be modified freely.To improve the UX, I would suggest
Internal Node
, which is limited to the internal ckb node, as the light client did,Internal Node
won't connect to an outside node;Internal Node
isdefault node
is selected while its name and IP are not changed;default node
have been changed, it will be treated as user-set network and won't be removed;default node
network once it's not active.This update should be fully delivered to users because it may mislead users that data have been changed unexpectedly.
This update can be published with the new UI and marked as an intentional change for the unified style.
The text was updated successfully, but these errors were encountered: