Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the built-in CKB node #200

Closed
Keith-CY opened this issue Jun 24, 2023 · 10 comments
Closed

Rename the built-in CKB node #200

Keith-CY opened this issue Jun 24, 2023 · 10 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@Keith-CY
Copy link
Member

Keith-CY commented Jun 24, 2023

default node was used to denote the internal ckb node before. There're 2 problems:

  1. Name convention of default node is not classical, typically it should be capitalized as Default Node
  2. default node is not exactly what it represents, it was meant to be the built-in ckb node. But now, the default node can be modified freely.

To improve the UX, I would suggest

  1. Add a network named Internal Node, which is limited to the internal ckb node, as the light client did, Internal Node won't connect to an outside node;
  2. Switch to the Internal Node is default node is selected while its name and IP are not changed;
  3. If the name/IP of the default node have been changed, it will be treated as user-set network and won't be removed;
  4. Remove the default node network once it's not active.

This update should be fully delivered to users because it may mislead users that data have been changed unexpectedly.

This update can be published with the new UI and marked as an intentional change for the unified style.

@Keith-CY Keith-CY added the documentation Improvements or additions to documentation label Jun 24, 2023
@Keith-CY Keith-CY added this to Neuron Jun 24, 2023
@Danie0918 Danie0918 moved this to 📌Planning in Neuron Jun 26, 2023
@yanguoyu
Copy link

yanguoyu commented Aug 21, 2023

  1. Check the network, if the mainnet work information is the same as the default. Rename the name to Internal Node, otherwise, add a network named Internal Node
  2. Move Internal Node to the top if they are not.
  3. Disable edit the Internal Node node.

@yanguoyu yanguoyu assigned yanguoyu and Sven-TBD and unassigned Danie0918 and Sven-TBD Aug 22, 2023
@yanguoyu
Copy link

We should ignore the network chain and genesisHash change because the network type will change by the current start network.

@Keith-CY
Copy link
Member Author

We should ignore the network chain and genesisHash change because the network type will change by the current start network.

The chain type and genesis hash are decoupled with the name and ip, in which step will they be involved in this update?

@yanguoyu
Copy link

We should ignore the network chain and genesisHash change because the network type will change by the current start network.

The chain type and genesis hash are decoupled with the name and ip, in which step will they be involved in this update?

When checking whether the user has changed the default node, we will ignore chain and genesisHash, Neuron changes them.

@Keith-CY
Copy link
Member Author

Keith-CY commented Aug 25, 2023

We should ignore the network chain and genesisHash change because the network type will change by the current start network.

The chain type and genesis hash are decoupled with the name and ip, in which step will they be involved in this update?

When checking whether the user has changed the default node, we will ignore chain and genesisHash, Neuron changes them.

Yes, chain and genesisHash are ignored when checking if the default network option has been updated. The fields to check are limited to name and url

@yanguoyu
Copy link

@yanguoyu yanguoyu moved this from 📌Planning to 👀 Testing in Neuron Aug 30, 2023
@Danie0918 Danie0918 moved this from 👀 Testing to 🚩Pre Release in Neuron Sep 4, 2023
@Danie0918 Danie0918 moved this from 🚩Pre Release to 📌Planning in Neuron Oct 11, 2023
@Danie0918
Copy link
Contributor

Currently there is no restriction on linking users to external nodes here, need to add restrictions like light client nodes.

@Keith-CY
Copy link
Member Author

Currently there is no restriction on linking users to external nodes here, need to add restrictions like light client nodes.

To inform users about this update, a dialog could be displayed when the internal node is selected but an external node is detected, and guide users to add a new network option for the external node.

@Keith-CY
Copy link
Member Author

Currently there is no restriction on linking users to external nodes here, need to add restrictions like light client nodes.

To inform users about this update, a dialog could be displayed when the internal node is selected but an external node is detected, and guide users to add a new network option for the external node.

To be more specific:

  1. Show a dialog when the internal node is active but an external node is detected
  2. Inform user that Internal node is reserved for the built-in node, if he/she wants to keep using the external one, he/she can switch to another network connection or add a new network connection
  3. The network connection list can be listed in the dialog for quick action
  4. The add a new network option can be listed to go to the editor quickly

@Danie0918
Copy link
Contributor

Will be fixed in #284

@yanguoyu yanguoyu moved this from 📌Planning to 🚩Pre Release in Neuron Nov 15, 2023
@Keith-CY Keith-CY moved this from 🚩Pre Release to ✅ Done in Neuron Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Archived in project
Development

No branches or pull requests

4 participants