Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniform the filter component #733

Open
poor-defined opened this issue Jul 5, 2024 · 1 comment
Open

Uniform the filter component #733

poor-defined opened this issue Jul 5, 2024 · 1 comment
Assignees

Comments

@poor-defined
Copy link
Contributor

There're at least two filter components in ckb explorer,

  1. One is RGB++ list filter

Image

  1. One is XUDT list filter

Image

I think they should be uniform, and it would be a great component if there are two types of view, one of which could show us which condition is applied. like belows:

Image

这个组件可以做2种模式,一种就是应用后很简单的高亮,也就是XUDT那种,适合手机用,一种是可以简单显示当前有哪些过滤条件。

@poor-defined poor-defined converted this from a draft issue Jul 5, 2024
@Kirl70
Copy link

Kirl70 commented Jul 5, 2024

The current radio popup style has been changed to be consistent with the checkbox pop-up box style. After application, the icon for the filter needs to be highlighted.

https://www.figma.com/design/6XNoimRDbFTTNm016rbIdU/Magickbase?node-id=35067-23847&t=NFMWxlE8d5bVWoXM-1
image

Additionally, displaying the current filter conditions is only applicable for multi-select scenarios, as the single-select condition will clearly indicate the selected content on the page.
https://www.figma.com/design/6XNoimRDbFTTNm016rbIdU/Magickbase?node-id=36828-30133&t=NFMWxlE8d5bVWoXM-1

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🎨 Designing
Development

No branches or pull requests

2 participants