Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open sources script could be lightspotted to get more attention #722

Closed
Keith-CY opened this issue Jul 1, 2024 · 12 comments · Fixed by Magickbase/ckb-explorer-frontend#417
Assignees
Labels

Comments

@Keith-CY
Copy link
Member

Keith-CY commented Jul 1, 2024

This feature request comes from the community.


A link to the source code will be available on the script list page if the script is open-sourced
image

If the open-sourced script and its tag are more noticeable and attract more attention, more teams would be inclined to reveal the source code.

@Kirl70
Copy link

Kirl70 commented Jul 10, 2024

We can add an Open Source tag to the list and place an open source icon in front of the tag.

https://www.figma.com/design/6XNoimRDbFTTNm016rbIdU/Magickbase?node-id=40117-52876&t=IYZtnwKd8IA9SeYA-1
image

image

@Keith-CY
Copy link
Member Author

I think the intention is to highlight open-sourced script in other places because the source code link already implies that this one is open-sourced.

BTW, general users won't visit the script list page. Most visitors are developers.

The highlight could be added, e.g.
image
image
image
image

A token will be more reliable when its code is open-sourced.

cc @Sven-TBD

@Kirl70
Copy link

Kirl70 commented Jul 11, 2024

Can you create a PRD to explain how the adjustments should be made? @Sven-TBD

@poor-defined
Copy link
Contributor

Can you create a PRD to explain how the adjustments should be made? @Sven-TBD

Please check here

@Kirl70
Copy link

Kirl70 commented Jul 16, 2024

Display the open-source icon in the specified location with the corresponding tooltip.
https://www.figma.com/design/6XNoimRDbFTTNm016rbIdU/Magickbase?node-id=33413-35843&t=kMIJoxafkCj1AINj-1
image

Show the open-source tag in the XUDT list header.
https://www.figma.com/design/6XNoimRDbFTTNm016rbIdU/Magickbase?node-id=36828-30133&t=kMIJoxafkCj1AINj-1
image

@Keith-CY
Copy link
Member Author

I found another page that should be marked with open source
Script detail page: https://explorer.nervos.org/script/0x70d64497a075bd651e98ac030455ea200637ee325a12ad08aff03f1a117e5a62/type

@poor-defined
Copy link
Contributor

I would recommend to put it here
image
@Kirl70 cc @Keith-CY

@Keith-CY
Copy link
Member Author

I would recommend to put it here image @Kirl70 cc @Keith-CY

Not every script has its type id, only those can be referenced by type script have type id.

Maybe we can add a new field for the script to denote its feature, e.g. open-sourced, token, swap, stake, etc.

@poor-defined
Copy link
Contributor

I would recommend to put it here image @Kirl70 cc @Keith-CY

Not every script has its type id, only those can be referenced by type script have type id.

Maybe we can add a new field for the script to denote its feature, e.g. open-sourced, token, swap, stake, etc.

Yes, we can add an other field for script. open-sourced is easy to added currently, however, about the other tags, should we add it by a vote function as well? @Keith-CY

@Keith-CY
Copy link
Member Author

Keith-CY commented Jul 26, 2024

I would recommend to put it here image @Kirl70 cc @Keith-CY

Not every script has its type id, only those can be referenced by type script have type id.
Maybe we can add a new field for the script to denote its feature, e.g. open-sourced, token, swap, stake, etc.

Yes, we can add an other field for script. open-sourced is easy to added currently, however, about the other tags, should we add it by a vote function as well? @Keith-CY

These scripts are submitted or collected manually(almost all scripts come from partners) so the tags can be added based on their feedback.

@Keith-CY
Copy link
Member Author

I would recommend to put it here image @Kirl70 cc @Keith-CY

Not every script has its type id, only those can be referenced by type script have type id.
Maybe we can add a new field for the script to denote its feature, e.g. open-sourced, token, swap, stake, etc.

Yes, we can add an other field for script. open-sourced is easy to added currently, however, about the other tags, should we add it by a vote function as well? @Keith-CY

These scripts are submitted or collected manually(almost all scripts come from partners) so the tags can be added based on their feedback.

scripts are kinda different from assets, scripts are actually protocols, and it's always easy to find protocols authors.

@Kirl70
Copy link

Kirl70 commented Aug 5, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

5 participants