Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support merging holders when export holders #717

Open
Keith-CY opened this issue Jun 28, 2024 · 5 comments
Open

Support merging holders when export holders #717

Keith-CY opened this issue Jun 28, 2024 · 5 comments
Assignees
Labels

Comments

@Keith-CY
Copy link
Member

This feature request comes from the community.


The xudt holder list can be exported at https://explorer.nervos.org/export-xudt-holders?id={xudt_type_hash}

Each CKB Adderss will be one entry in the list, but not every holder has only one CKB Address. When the holder uses a BTC Address, he/she main own various CKB Address due to RGB++ protocol.

That's why there's a column named owner.

Because each CKB Address is an independent line, the owner will be repeated if it has various CKB Address.

The community member wonders if there can be an option to merge these owners by removing the CKB Address column so that they can get the count of owners directly.

There are two basic solutions:

  1. Users can select which column should be included before the export and if the CKB Address is not selected, the Owner Address will be the basic index of the list;
  2. Provide a clear option that Merge owner address for this function.

Extra solution can be added.

@rabbitz
Copy link

rabbitz commented Jul 19, 2024

PR: nervosnetwork/ckb-explorer#2086
Readme: https://ckb-explorer.readme.io/reference/xudt-snapshot

Add the merge_with_owner parameter with a default value of false. When false, return the CKB Address column; when true, return the Owner column.

@rabbitz rabbitz moved this from 🏗 In Progress to 👀 Testing in CKB Explorer Jul 19, 2024
@FrederLu
Copy link

PR: nervosnetwork/ckb-explorer#2086 Readme: https://ckb-explorer.readme.io/reference/xudt-snapshot

Add the merge_with_owner parameter with a default value of false. When false, return the CKB Address column; when true, return the Owner column.

The API data has been verified.
The front end needs to process merge_with_owner: true. Now the default is false to export CKB address information. @Sven-TBD

@Kirl70
Copy link

Kirl70 commented Jul 22, 2024

@FrederLu FrederLu moved this from 👀 Testing to 🏗 In Progress in CKB Explorer Jul 29, 2024
@PainterPuppets
Copy link

设计草稿(12-4--12-8): https://www.figma.com/design/6XNoimRDbFTTNm016rbIdU/Magickbase ?node-id=39141-49780&t=EnDccGZwxkTqaevy-1 图像

图像

The xudt holder export only seems to support a specific block, so there should be no switch between date and block, as well as the backend is returning the csv data directly so i think it should be downloaded directly

@FrederLu
Copy link

FrederLu commented Aug 7, 2024

Verified.

@FrederLu FrederLu moved this from 👀 Testing to ✅ Done in CKB Explorer Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

No branches or pull requests

6 participants