Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Done button functionality is missing. #709

Closed
FrederLu opened this issue Jun 20, 2024 · 4 comments · Fixed by Magickbase/ckb-explorer-frontend#395
Closed

Done button functionality is missing. #709

FrederLu opened this issue Jun 20, 2024 · 4 comments · Fixed by Magickbase/ckb-explorer-frontend#395
Assignees
@PainterPuppets
Labels
bug Something isn't working

Comments

@FrederLu
Copy link

2024-06-20.16.18.15.mov
image image

I found that the Done button does not work when selecting Language and Node. After making the corresponding selection, it will take effect without confirmation.
@FrederLu FrederLu added the bug Something isn't working label Jun 20, 2024
@Sven-TBD Sven-TBD moved this to 🆕 New in CKB Explorer Jun 21, 2024
@Sven-TBD
Copy link
Contributor

@PainterPuppets Hi Tao, Could you have a look at this when you are free.

@PainterPuppets
Copy link

PainterPuppets commented Jun 21, 2024 •
edited
Loading

It feels like switching states directly should be intuitive to use. Is this Done more like the close?

I'm not sure, can you decide on the exact interaction logic? @Sven-TBD

@github-actions github-actions bot mentioned this issue Jun 21, 2024
Merged
@Sven-TBD
Copy link
Contributor

Sven-TBD commented Jul 4, 2024

@PainterPuppets yes, we could just remove the "Done" button.

Image

https://vs0cjf.axshare.com/?id=7um3d9&g=14

@Sven-TBD Sven-TBD moved this from 🆕 New to 🏗 In Progress in CKB Explorer Jul 4, 2024
@Sven-TBD Sven-TBD removed their assignment Jul 4, 2024
@PainterPuppets PainterPuppets mentioned this issue Jul 5, 2024
Merged
@github-actions github-actions bot mentioned this issue Jul 5, 2024
Merged
@FrederLu FrederLu moved this from 🏗 In Progress to 👀 Testing in CKB Explorer Jul 8, 2024
@FrederLu
Copy link
Author

FrederLu commented Jul 8, 2024

Verified.

@FrederLu FrederLu moved this from 👀 Testing to ✅ Done in CKB Explorer Jul 8, 2024
@github-actions github-actions bot mentioned this issue Jul 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PainterPuppets PainterPuppets

Labels
bug Something isn't working
Projects
CKB Explorer
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove Done button PainterPuppets/ckb-explorer-frontend
3 participants
@PainterPuppets @FrederLu @Sven-TBD