Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Remove the index.d.ts file and move its types to the appropriate location #434

Closed
WhiteMinds opened this issue Sep 19, 2023 · 1 comment
Closed

Refactor: Remove the index.d.ts file and move its types to the appropriate location #434

WhiteMinds opened this issue Sep 19, 2023 · 1 comment
Assignees
@WhiteMinds
Labels
refactor

Comments

@WhiteMinds
Copy link

By the way, organize the names of these types, their inheritance and composition relationships, etc.
@WhiteMinds WhiteMinds self-assigned this Sep 19, 2023
@WhiteMinds WhiteMinds mentioned this issue Sep 19, 2023
Open
2 tasks
@Keith-CY Keith-CY moved this to 📋 Backlog in CKB Explorer Sep 25, 2023
@WhiteMinds WhiteMinds moved this from 📋 Backlog to 🏗 In Progress in CKB Explorer Sep 26, 2023
This was referenced Sep 27, 2023
Closed
Merged
@WhiteMinds
Copy link
Author

WhiteMinds commented Sep 27, 2023 •
edited
Loading

This issue will have multiple PRs.

Here are the PRs that have already been created:

  1. Refactor: optimize and simplify the routes code ckb-explorer-frontend#108
  2. Refactor: move fetcher codes to ExplorerService ckb-explorer-frontend#115
  3. Refactor: some fetcher-related code ckb-explorer-frontend#121
  4. Refactor: Remove the index.d.ts file and move its types to the appropriate location ckb-explorer-frontend#124

@WhiteMinds WhiteMinds mentioned this issue Oct 7, 2023
Merged
@WhiteMinds WhiteMinds mentioned this issue Oct 20, 2023
Merged
@WhiteMinds WhiteMinds moved this from 🏗 In Progress to ✅ Done in CKB Explorer Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WhiteMinds WhiteMinds

Labels
refactor
Projects
CKB Explorer
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@WhiteMinds