-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uvloop breaks aiohttp's capability of serving static files #50
Comments
What version of aiohttp are you using? AFAIK there was an issue with how aiohttp implemented sendfile, which was fixed not long ago. cc @asvetlov |
Hi @1st1 , Unfortunately I'm already using the latest version, which is Thanks for the quick reply :-) |
There is aio-libs/aiohttp#1093 issue. |
Hmmm... makes sense... Should we close this issue as a duplicate? Want me to refer it in the other one? [EDIT] Already done, sorry. You can close this one if you want. |
@1st1 please close the issue as aio-libs/aiohttp#1093 is resolved. |
@asvetlov When will you release aiohttp with this thing fixed? |
@1st1 just after fixing bugs with cookiejar. |
Closing the issue since it has been resolved in aiohttp. |
uvloop
breaks aiohttp's capability of serving static files. It makes the server send the response headers after the body.To run this, have aiohttp and uvloop installed, then run the gist ( https://gist.github.com/diogobaeder/0558c43d785cd82a1ecff553bc583867 ):
$ python uvhttp.py
Then make a request to the app, making sure to get verbose output:
$ curl -v localhost:8765/jquery.js
These are the results I'm getting when serving jQuery:
Notice how with uvloop the response headers are sent after the body.
I'm not acquainted with the internals of
aiohttp
oruvloop
, but it seems that the former relies on some parser fromasyncio
anduvloop
seems to replace it by another one that behaves differently.Any ideas of why this happens? At the moment this is preventing me to use
uvloop
, unfortunately...Thanks!
The text was updated successfully, but these errors were encountered: