From cf3f4c72df4d0f05de03ae33325fb231c56ef8db Mon Sep 17 00:00:00 2001 From: Kristjan ESPERANTO <35647502+KristjanESPERANTO@users.noreply.github.com> Date: Sat, 19 Oct 2024 02:32:54 +0200 Subject: [PATCH] Run and test with node 23 --- .github/CONTRIBUTING.md | 2 +- .github/ISSUE_TEMPLATE.md | 2 +- .github/workflows/automated-tests.yaml | 2 +- .github/workflows/electron-rebuild.yaml | 2 +- CHANGELOG.md | 1 + package-lock.json | 2 +- package.json | 2 +- 7 files changed, 7 insertions(+), 6 deletions(-) diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index 360ea62189..1166747bd5 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -43,7 +43,7 @@ When submitting a new issue, please supply the following information: **Platform**: Place your platform here... give us your web browser/Electron version _and_ your hardware (Raspberry Pi 2/3/4, Windows, Mac, Linux, System V UNIX). -**Node Version**: Make sure it's version 18 or later (recommended is 20). +**Node Version**: Make sure it's version 20 or later (recommended is 22). **MagicMirror² Version**: Please let us know which version of MagicMirror² you are running. It can be found in the `package.json` file. diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index f24edfc4b0..2aa4b4d87f 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -35,7 +35,7 @@ When submitting a new issue, please supply the following information: **Platform**: Place your platform here... give us your web browser/Electron version _and_ your hardware (Raspberry Pi 2/3/4, Windows, Mac, Linux, System V UNIX). -**Node Version**: Make sure it's version 18 or later (recommended is 20). +**Node Version**: Make sure it's version 20 or later (recommended is 22). **MagicMirror² Version**: Please let us know which version of MagicMirror² you are running. It can be found in the `package.json` file. diff --git a/.github/workflows/automated-tests.yaml b/.github/workflows/automated-tests.yaml index e48acd9bcc..1c64d3a727 100644 --- a/.github/workflows/automated-tests.yaml +++ b/.github/workflows/automated-tests.yaml @@ -18,7 +18,7 @@ jobs: timeout-minutes: 30 strategy: matrix: - node-version: [20.9.0, 20.x, 22.x] + node-version: [20.9.0, 20.x, 22.x, 23.x] steps: - name: "Checkout code" uses: actions/checkout@v4 diff --git a/.github/workflows/electron-rebuild.yaml b/.github/workflows/electron-rebuild.yaml index e5bfa13c3e..5c5e9b5a3f 100644 --- a/.github/workflows/electron-rebuild.yaml +++ b/.github/workflows/electron-rebuild.yaml @@ -8,7 +8,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - node-version: [20.9.0, 20.x, 22.x] + node-version: [20.9.0, 20.x, 22.x, 23.x] steps: - name: Checkout code uses: actions/checkout@v4 diff --git a/CHANGELOG.md b/CHANGELOG.md index c31665ac36..570b041087 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -22,6 +22,7 @@ _This release is scheduled to be released on 2025-01-01._ - [repo] reactivated `stale.yaml` as github action to mark issues as stale after 60 days and close them 7 days later (if no activity) - [core] Update electron dependency to v32 (test electron rebuild) - [tests] All test configs have been updated to allow full external access, allowing for easier debugging (especially when running as a container) +- [core] Run and test with node 23 ### Fixed diff --git a/package-lock.json b/package-lock.json index 985f396fbc..a570db2ff8 100644 --- a/package-lock.json +++ b/package-lock.json @@ -50,7 +50,7 @@ "stylelint-prettier": "^5.0.2" }, "engines": { - "node": ">=20.9.0 <21 || 22" + "node": ">=20.9.0 <21 || 22 || >=23" }, "optionalDependencies": { "electron": "^32.2.0" diff --git a/package.json b/package.json index 75fc840d6e..35be4b4424 100644 --- a/package.json +++ b/package.json @@ -98,7 +98,7 @@ "electron": "^32.2.0" }, "engines": { - "node": ">=20.9.0 <21 || 22" + "node": ">=20.9.0 <21 || 22 || >=23" }, "_moduleAliases": { "node_helper": "js/node_helper.js",