From e50655ab6e7bdc1be7b9171567f80688bd571239 Mon Sep 17 00:00:00 2001 From: Mark Date: Fri, 8 Mar 2024 14:53:44 +0100 Subject: [PATCH 1/4] change layout of current weather indoor values --- modules/default/weather/current.njk | 42 ++++++++++++++++------------- 1 file changed, 23 insertions(+), 19 deletions(-) diff --git a/modules/default/weather/current.njk b/modules/default/weather/current.njk index e7a7e3f1b6..1fa9103dde 100644 --- a/modules/default/weather/current.njk +++ b/modules/default/weather/current.njk @@ -12,8 +12,7 @@ {% if config.showWindDirection %} {% if config.showWindDirectionAsArrow %} - + {% else %} {{ current.cardinalWindDirection() | translate }} {% endif %} @@ -42,25 +41,30 @@ {% endif %} {% endif %} -
- - {{ current.temperature | roundValue | unit("temperature") | decimalSymbol }} - {% if config.showHumidity === "temp" %} - {{ humidity() }} - {% endif %} -
-
+
{% if config.showIndoorTemperature and indoor.temperature %} -
- - {{ indoor.temperature | roundValue | unit("temperature") | decimalSymbol }} -
+ + + {% if config.showIndoorTemperature and indoor.temperature %} + + + {{ indoor.temperature | roundValue | unit("temperature") | decimalSymbol }} + + + {% endif %} + {% if config.showIndoorHumidity and indoor.humidity %} + + + {{ indoor.humidity | roundValue | unit("humidity") | decimalSymbol }} + + + {% endif %} + {% endif %} - {% if config.showIndoorHumidity and indoor.humidity %} -
- - {{ indoor.humidity | roundValue | unit("humidity") | decimalSymbol }} -
+ + {{ current.temperature | roundValue | unit("temperature") | decimalSymbol }} + {% if config.showHumidity === "temp" %} + {{ humidity() }} {% endif %}
{% if (config.showFeelsLike or config.showPrecipitationAmount or config.showPrecipitationProbability) and not config.onlyTemp %} From ce4f8e48df44dc1679758dac47c9e3fe751a163d Mon Sep 17 00:00:00 2001 From: Mark Date: Fri, 8 Mar 2024 14:59:23 +0100 Subject: [PATCH 2/4] change layout of current weather indoor values --- modules/default/weather/current.njk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/default/weather/current.njk b/modules/default/weather/current.njk index 1fa9103dde..d19848954e 100644 --- a/modules/default/weather/current.njk +++ b/modules/default/weather/current.njk @@ -42,7 +42,7 @@
{% endif %}
- {% if config.showIndoorTemperature and indoor.temperature %} + {% if config.showIndoorTemperature and indoor.temperature or config.showIndoorHumidity and indoor.humidity %} {% if config.showIndoorTemperature and indoor.temperature %} From 97952d37f66e2887f28390c47b4f5dcb97f0c25c Mon Sep 17 00:00:00 2001 From: Mark Date: Fri, 8 Mar 2024 15:08:23 +0100 Subject: [PATCH 3/4] adapt tests --- tests/e2e/modules/weather_current_spec.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/e2e/modules/weather_current_spec.js b/tests/e2e/modules/weather_current_spec.js index ac66873b90..d24ea1b133 100644 --- a/tests/e2e/modules/weather_current_spec.js +++ b/tests/e2e/modules/weather_current_spec.js @@ -19,7 +19,7 @@ describe("Weather module", () => { }); it("should render temperature with icon", async () => { - await expect(weatherFunc.getText(".weather .large.light span.bright", "1.5°")).resolves.toBe(true); + await expect(weatherFunc.getText(".weather .large span.light.bright", "1.5°")).resolves.toBe(true); }); it("should render feels like temperature", async () => { @@ -62,7 +62,7 @@ describe("Weather module", () => { }); it("should render degreeLabel for temp", async () => { - await expect(weatherFunc.getText(".weather .large.light span.bright", "1°C")).resolves.toBe(true); + await expect(weatherFunc.getText(".weather .large span.bright.light", "1°C")).resolves.toBe(true); }); it("should render degreeLabel for feels like", async () => { @@ -80,7 +80,7 @@ describe("Weather module", () => { }); it("should render temperatures in fahrenheit", async () => { - await expect(weatherFunc.getText(".weather .large.light span.bright", "34,7°")).resolves.toBe(true); + await expect(weatherFunc.getText(".weather .large span.bright.light", "34,7°")).resolves.toBe(true); }); it("should render 'feels like' in fahrenheit", async () => { From a98f3d557734106fb070b3b2b3a7755b6327e1b9 Mon Sep 17 00:00:00 2001 From: Mark Date: Fri, 8 Mar 2024 15:40:04 +0100 Subject: [PATCH 4/4] fill CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index d8353ea0e3..44ed10167d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -26,6 +26,7 @@ _This release is scheduled to be released on 2024-04-01._ - [chore] Update dependencies including electron to v28 (#3357) and node-ical - Updated translations for estonian (#3371) - Update electron to v29 and update other dependencies +- Updated layout of current weather indoor values ### Fixed