From fed18684718a6c67fdac0f3e940c69d1f97ef0ac Mon Sep 17 00:00:00 2001 From: Eddie Hung <6740044+eddiehung@users.noreply.github.com> Date: Sat, 20 May 2023 16:36:54 -0700 Subject: [PATCH 1/2] Fix envcanada today pop --- modules/default/weather/providers/envcanada.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/default/weather/providers/envcanada.js b/modules/default/weather/providers/envcanada.js index c0f028910d..4c0bf02f5b 100644 --- a/modules/default/weather/providers/envcanada.js +++ b/modules/default/weather/providers/envcanada.js @@ -505,9 +505,9 @@ WeatherProvider.register("envcanada", { } // Check Today element for POP - - if (foreGroup[today].querySelector("abbreviatedForecast pop").textContent > 0) { - weather.precipitationProbability = foreGroup[today].querySelector("abbreviatedForecast pop").textContent; + const precipPOP = foreGroup[today].querySelector("abbreviatedForecast pop").textContent * 1.0; + if (precipPOP > 0) { + weather.precipitationProbability = precipPOP; } }, From 69a12be256391bc5c42cfe42cc789bd05f40f963 Mon Sep 17 00:00:00 2001 From: Eddie Hung <6740044+eddiehung@users.noreply.github.com> Date: Sat, 20 May 2023 17:03:33 -0700 Subject: [PATCH 2/2] Add changelog entry --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 54e3dc173a..507f389bd5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -34,6 +34,7 @@ _This release is scheduled to be released on 2023-07-01._ - Fix style issues after eslint-plugin-jsdoc update - Fix don't filter out ongoing full day events (#3095) - Fix date not shown when clock in analog mode (#3100) +- Fix envcanada today percentage-of-precipitation (#3106) ## [2.23.0] - 2023-04-04