From 0ef508824ceea50465f449bfbc44675a2bce1bbd Mon Sep 17 00:00:00 2001 From: veeck Date: Wed, 15 Feb 2023 22:19:51 +0100 Subject: [PATCH] Do some debugging, remove not needed workflows for now --- .github/workflows/automated-tests.yaml | 39 ------------------- .github/workflows/codecov-test-suites.yaml | 33 ---------------- .github/workflows/depsreview.yaml | 18 --------- .../workflows/enforce-pullrequest-rules.yaml | 11 +++++- 4 files changed, 10 insertions(+), 91 deletions(-) delete mode 100644 .github/workflows/automated-tests.yaml delete mode 100644 .github/workflows/codecov-test-suites.yaml delete mode 100644 .github/workflows/depsreview.yaml diff --git a/.github/workflows/automated-tests.yaml b/.github/workflows/automated-tests.yaml deleted file mode 100644 index 28957b000d..0000000000 --- a/.github/workflows/automated-tests.yaml +++ /dev/null @@ -1,39 +0,0 @@ -# This workflow will do a clean install of node dependencies, build the source code and run tests across different versions of node -# For more information see: https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions - -name: "Run Automated Tests" - -on: - push: - branches: [master, develop] - pull_request: - branches: [master, develop] - -permissions: - contents: read - -jobs: - test: - runs-on: ubuntu-latest - timeout-minutes: 30 - strategy: - matrix: - node-version: [14.x, 16.x, 18.x] - steps: - - name: "Checkout code" - uses: actions/checkout@v3 - - name: "Use Node.js ${{ matrix.node-version }}" - uses: actions/setup-node@v3 - with: - node-version: ${{ matrix.node-version }} - cache: "npm" - - name: "Install dependencies and run tests" - run: | - Xvfb :99 -screen 0 1024x768x16 & - export DISPLAY=:99 - npm run install-mm:dev - touch css/custom.css - npm run test:prettier - npm run test:js - npm run test:css - npm run test diff --git a/.github/workflows/codecov-test-suites.yaml b/.github/workflows/codecov-test-suites.yaml deleted file mode 100644 index 8cdcccbb7e..0000000000 --- a/.github/workflows/codecov-test-suites.yaml +++ /dev/null @@ -1,33 +0,0 @@ -# This workflow runs the automated test and uploads the coverage results to codecov.io -# For more information see: https://github.com/codecov/codecov-action - -name: "Run Codecov Tests" - -on: - push: - branches: [master, develop] - pull_request: - branches: [master, develop] - -permissions: - contents: read - -jobs: - run-and-upload-coverage-report: - runs-on: ubuntu-latest - timeout-minutes: 30 - steps: - - name: "Checkout code" - uses: actions/checkout@v3 - - name: "Install dependencies and run coverage" - run: | - Xvfb :99 -screen 0 1024x768x16 & - export DISPLAY=:99 - npm ci - touch css/custom.css - npm run test:coverage - - name: "Upload coverage results to codecov" - uses: codecov/codecov-action@v3 - with: - files: ./coverage/lcov.info - fail_ci_if_error: true diff --git a/.github/workflows/depsreview.yaml b/.github/workflows/depsreview.yaml deleted file mode 100644 index 308f0017d0..0000000000 --- a/.github/workflows/depsreview.yaml +++ /dev/null @@ -1,18 +0,0 @@ -# This workflow scans your pull requests for dependency changes, and will raise an error if any vulnerabilities or invalid licenses are being introduced. -# For more information see: https://github.com/actions/dependency-review-action - -name: "Review Dependencies" - -on: [pull_request] - -permissions: - contents: read - -jobs: - dependency-review: - runs-on: ubuntu-latest - steps: - - name: "Checkout code" - uses: actions/checkout@v3 - - name: "Dependency Review" - uses: actions/dependency-review-action@v3 diff --git a/.github/workflows/enforce-pullrequest-rules.yaml b/.github/workflows/enforce-pullrequest-rules.yaml index 809118b096..6274aba043 100644 --- a/.github/workflows/enforce-pullrequest-rules.yaml +++ b/.github/workflows/enforce-pullrequest-rules.yaml @@ -18,10 +18,19 @@ jobs: with: changeLogPath: "CHANGELOG.md" skipLabels: "Skip Changelog" + - name: "DEBUG" + run: | + echo "base_ref" + echo ${{ github.base_ref }} + echo "comp" + echo ${{ !contains(github.event.pull_request.labels.*.name, 'question') }} + echo ${{ github.base_ref == 'develop' }} + echo ${{ !contains(github.event.pull_request.labels.*.name, 'question') && github.base_ref == 'develop' }} - name: "Enforce develop branch" if: ${{ !contains(github.event.pull_request.labels.*.name, 'question') && github.base_ref == 'develop' }} run: | - echo "This PR is based against the master branch. Please don't do this. Switch the branch to 'develop'." + echo "This PR is based against the master branch and not a release or hotfix. + Please don't do this. Switch the branch to 'develop'." exit 1 env: BASE_BRANCH: ${{ github.base_ref }}