[QA] Passage au niveau 2 de phpstan

[hmeneuvrier]

Le passage au niveau 1 a été fait ici #1221
Et n'a nécessité aucune correction d'erreur.

Le passage au niveau 2 necessite de corriger entre 100 et 150 erreurs pas trop difficiles (principalement des fonctions pas trouvées car objet non typé)

[hmeneuvrier]

Faire le test sur la branche de visite

[emilschn]

178 erreurs sur la branche de visites

[hmeneuvrier]

Develop 28 juin : [ERROR] Found 179 errors

[hmeneuvrier]

Plus que 30, mais en vrai 3.
Pourquoi dans SignalementRepository.php on utilise UserInterface au lieu de User, est-ce que je peux changer ?
L'erreur dans le ReferenceGenerator, je n'ai pas encore eu le temps de regarder
Et les erreurs sur les expects() dans les tests, je n'ai pas encore trouvé comment faire

`

---

Line src/Repository/SignalementRepository.php

---

369 Call to an undefined method Symfony\Component\Security\Core\User\UserInterface::isTerritoryAdmin().
370 Call to an undefined method Symfony\Component\Security\Core\User\UserInterface::getTerritory().
371 Call to an undefined method Symfony\Component\Security\Core\User\UserInterface::getTerritory().
374 Call to an undefined method Symfony\Component\Security\Core\User\UserInterface::getTerritory().
375 Call to an undefined method Symfony\Component\Security\Core\User\UserInterface::getPartner().
379 Call to an undefined method Symfony\Component\Security\Core\User\UserInterface::isPartnerAdmin().
379 Call to an undefined method Symfony\Component\Security\Core\User\UserInterface::isUserPartner().
380 Call to an undefined method Symfony\Component\Security\Core\User\UserInterface::getTerritory().
404 Call to an undefined method Symfony\Component\Security\Core\User\UserInterface::getPartner().
405 Call to an undefined method Symfony\Component\Security\Core\User\UserInterface::getPartner().
470 Call to an undefined method Symfony\Component\Security\Core\User\UserInterface::isPartnerAdmin().
470 Call to an undefined method Symfony\Component\Security\Core\User\UserInterface::isUserPartner().
480 Call to an undefined method Symfony\Component\Security\Core\User\UserInterface::getPartner().

---

---

Line src/Service/Signalement/ReferenceGenerator.php

---

21 Binary operation "+" between non-falsy-string and 1 results in an error.

---

---

Line tests/Unit/Service/Esabora/EsaboraManagerTest.php

---

37 Call to an undefined method App\Repository\InterventionRepository::expects().
42 Call to an undefined method App\Factory\InterventionFactory::expects().
46 Call to an undefined method App\Repository\InterventionRepository::expects().
64 Call to an undefined method App\Repository\InterventionRepository::expects().
69 Call to an undefined method App\Factory\InterventionFactory::expects().
87 Call to an undefined method App\Repository\InterventionRepository::expects().
92 Call to an undefined method App\Factory\InterventionFactory::expects().
96 Call to an undefined method App\Repository\InterventionRepository::expects().
114 Call to an undefined method App\Repository\InterventionRepository::expects().
119 Call to an undefined method App\Factory\InterventionFactory::expects().

---

---

Line tests/Unit/Service/Esabora/Handler/DossierAdresseServiceHandlerTest.php

---

32 Call to an undefined method App\Service\Esabora\EsaboraSISHService::expects().
37 Call to an undefined method App\Manager\JobEventManager::expects().

---

---

Line tests/Unit/Service/Esabora/Handler/DossierPersonneServiceHandlerTest.php

---

32 Call to an undefined method App\Service\Esabora\EsaboraSISHService::expects().
37 Call to an undefined method App\Manager\JobEventManager::expects().

---

---

Line tests/Unit/Service/Esabora/Handler/DossierServiceHandlerTest.php

---

32 Call to an undefined method App\Service\Esabora\EsaboraSISHService::expects().
37 Call to an undefined method App\Manager\JobEventManager::expects().

---

`

[hmeneuvrier]

15 erreurs supplémentaires pour passer au niveau 3, je l'ai fait... par contre 100 erreurs de plus pour le niveau 4, ce sera pour une autre fois