-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gwe-uze): stop simulation when area of uze object not equal to cell area #2073
fix(gwe-uze): stop simulation when area of uze object not equal to cell area #2073
Conversation
review comments included:
|
@langevin-usgs, some more work remains on this. When the GWF flows are provided to GWE in memory, the auxmultcol-adjusted area of each UZF object isn't set until the _ad() routines. So the current check (as of 52e6d7e) does not do the area comparison with the correct UZF areas.
where the argument |
0bc0a19
to
26ae1a9
Compare
…dices, comparing the area of individual UZF objects to the area of the host cell. They should be equal
ef5fcdc
to
cc393f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much better. Did this not work if the check was done at the end of rp? Just asking because this will require a loop through all nodes at the start of every time step (instead of stress period). Probably not a big deal. Other minor suggestions.
The check doesn't fail at the end of |
Based of how UZE is formulated, only one UZE object per grid cell is permitted. If more than one UZE object is discovered in a grid cell, GWE will now exit with an error message. To fix, users will need to remove the AUXMULTNAME keyword from the OPTIONS block of the corresponding UZF input file.
AUXMULTNAME
option inUZF
toGWE
#2048ruff
on new python script in autotest subdirectories.fprettify