ci: use -Doptimization=1 for arm mac test and release #1827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpbonelli
force-pushed
the
macos-14-gcc-opt
branch
from
a4d866d to
615413c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On rectangular grids, the generalized particle tracking method can find itself in an endless loop on macOS 14 compiled with gfortran with optimization=2, confirmed with gfortran 11-14.
It's difficult to say where things are going wrong since on ARM macs neither gdb nor lldb can be used so we are stuck with print debugging. An architecture/compiler problem seems plausible since we'd presumably see the same behavior on other platforms with opt=2 if it were our bug, but I'm not sure.
This should not occur typically since rectangular cells are detected and solved with Pollock's method, but we use
dev_forceternaryintest_prt_disv1.pyto check that the generalized method reduces to Pollock's. The test has been hanging in CI recently — we might have caught it sooner but there was a separatesetup-fortranissue which concealed this one at first.While it might be safe to release with optimization=2 (with the assumption developers are the only ones using dev options) I don't think we can be sure the same or similar issues could not affect other model grids. So I think we should drop the optimization level pending more information.