Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flags to the download Hermes command #3

Closed
2 tasks done
jessieAnhNguyen opened this issue Jul 22, 2020 · 1 comment · Fixed by #4
Closed
2 tasks done

Add flags to the download Hermes command #3

jessieAnhNguyen opened this issue Jul 22, 2020 · 1 comment · Fixed by #4
Assignees
@jessieAnhNguyen
Labels
enhancement New feature or request in progress priority-2

Comments

@jessieAnhNguyen
Copy link
Member

jessieAnhNguyen commented Jul 22, 2020 •
edited
Loading

Add moreoptions to the command:

  • Add a flag --raw: download the original Hermes sampling profile

    • Default (no flag): download the Chrome format profile that has been transformed from the origin Hermes profile

  • Add a flag --verbose: list out the adb commands that are run behind the scene of the react-native profile-hermes command
@jessieAnhNguyen jessieAnhNguyen self-assigned this Jul 22, 2020
@jessieAnhNguyen
Copy link
Member Author

jessieAnhNguyen commented Jul 30, 2020 •
edited
Loading

Done adding the 2 flags. Additional flag:

  • Add a flag --sourceMapPath <string>: user should provide the local path to their source map file
  • In the next version, will read the file from js bundle of the Android device

@jessieAnhNguyen jessieAnhNguyen mentioned this issue Jul 30, 2020
Merged
@jessieAnhNguyen jessieAnhNguyen linked a pull request Jul 30, 2020 that will close this issue
Integrated transformer tool into CLI #4
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessieAnhNguyen jessieAnhNguyen

Labels
enhancement New feature or request in progress priority-2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Integrated transformer tool into CLI MLH-Fellowship/cli
1 participant
@jessieAnhNguyen