From 654e53c677653d90d5ba2eff82233548df8a8c9f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marko=20Ba=C5=A1tovanovi=C4=87?= Date: Sat, 24 Nov 2018 01:33:19 +0100 Subject: [PATCH 1/3] Add link for MLP. Had to Google it --- docs/user/algorithms.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/user/algorithms.rst b/docs/user/algorithms.rst index d86ee30b2..6275448f6 100644 --- a/docs/user/algorithms.rst +++ b/docs/user/algorithms.rst @@ -16,7 +16,7 @@ The following algorithms are implemented in the Spinning Up package: - `Twin Delayed DDPG`_ (TD3) - `Soft Actor-Critic`_ (SAC) -They are all implemented with MLP (non-recurrent) actor-critics, making them suitable for fully-observed, non-image-based RL environments, eg the `Gym Mujoco`_ environments. +They are all implemented with `MLP`_ (non-recurrent) actor-critics, making them suitable for fully-observed, non-image-based RL environments, eg the `Gym Mujoco`_ environments. .. _`Gym Mujoco`: https://gym.openai.com/envs/#mujoco .. _`Vanilla Policy Gradient`: ../algorithms/vpg.html @@ -25,6 +25,7 @@ They are all implemented with MLP (non-recurrent) actor-critics, making them sui .. _`Deep Deterministic Policy Gradient`: ../algorithms/ddpg.html .. _`Twin Delayed DDPG`: ../algorithms/td3.html .. _`Soft Actor-Critic`: ../algorithms/sac.html +.. _`MLP`: https://en.wikipedia.org/wiki/Multilayer_perceptron Why These Algorithms? From f73547238c458c7597cc258f5ffbb61e6e3cac49 Mon Sep 17 00:00:00 2001 From: Marko Bastovanovic Date: Sat, 24 Nov 2018 02:51:38 +0100 Subject: [PATCH 2/3] Give helpful message in case Matplotlib isn't working https://github.com/openai/spinningup/issues/1 --- spinup/utils/plot.py | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/spinup/utils/plot.py b/spinup/utils/plot.py index e8d253dab..945ff97ac 100644 --- a/spinup/utils/plot.py +++ b/spinup/utils/plot.py @@ -1,4 +1,15 @@ -import seaborn as sns +import sys +try: + import seaborn as sns +except ImportError as e: + if "Python is not installed as a framework" in str(e): + print("It looks like you are using OSX and Anaconda setup, without " + "Matplotlib properly configured. \nIssuing this from the command " + "line should fix the problem:\n" + "echo \"backend: TkAgg\" >> ~/.matplotlib/matplotlibrc\n" + "For more info see " + "https://github.com/openai/spinningup/issues/1\n") + sys.exit(2) import pandas as pd import matplotlib.pyplot as plt import json From 858c57ad329a099303f3e18718876e7bc1620204 Mon Sep 17 00:00:00 2001 From: Marko Bastovanovic Date: Sat, 24 Nov 2018 09:44:39 +0100 Subject: [PATCH 3/3] Revert "Give helpful message in case Matplotlib isn't working" This reverts commit f73547238c458c7597cc258f5ffbb61e6e3cac49. --- spinup/utils/plot.py | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/spinup/utils/plot.py b/spinup/utils/plot.py index 945ff97ac..e8d253dab 100644 --- a/spinup/utils/plot.py +++ b/spinup/utils/plot.py @@ -1,15 +1,4 @@ -import sys -try: - import seaborn as sns -except ImportError as e: - if "Python is not installed as a framework" in str(e): - print("It looks like you are using OSX and Anaconda setup, without " - "Matplotlib properly configured. \nIssuing this from the command " - "line should fix the problem:\n" - "echo \"backend: TkAgg\" >> ~/.matplotlib/matplotlibrc\n" - "For more info see " - "https://github.com/openai/spinningup/issues/1\n") - sys.exit(2) +import seaborn as sns import pandas as pd import matplotlib.pyplot as plt import json