Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ros unit tests #56

Open
wants to merge 29 commits into
base: master
Choose a base branch
from
Open

Feature/ros unit tests #56

wants to merge 29 commits into from

Conversation

violetteavi
Copy link
Contributor

@violetteavi violetteavi commented Apr 1, 2020

Adding unit tests for all classes

  • Testing setup (Compiling with gtest, running tests with gdb, fake ros nodes, etc)
  • RosDataProviderInterface
  • RosOnlineDataProvider
  • RosBagDataProvider
  • KimeraVioRos

@violetteavi
Copy link
Contributor Author

I pulled as many of the testPipeline.cpp tests from Kimera-VIO as I could without modifying the underlying code. I was only able to get 6/16 working with the RosbagDataProvider, as it does not have a sequential mode and does not shut itself down. See this issue for more details.

@violetteavi violetteavi marked this pull request as ready for review April 9, 2020 16:40
@violetteavi
Copy link
Contributor Author

I'm going to put test development on the backburner for now. I think the testing infrastructure used here is useful enough to merit merging into master. I could see an argument for not merging until the test suite is complete, but that may be a while.

@violetteavi violetteavi requested a review from ToniRV April 9, 2020 16:47
@violetteavi violetteavi mentioned this pull request May 13, 2020
3 tasks
violetteavi and others added 4 commits May 12, 2020 21:57
…ture/ros_unit_tests

* 'master' of github.com:MIT-SPARK/Kimera-VIO-ROS: (35 commits)
  Deprecate Kitti support
  Separate spin into parallelSpin and sequentialSpin
  Require ctrl+c from user instead of autoShutdown
  Minor
  Add mesh rviz viz as dependency
  Use /home/tonirv in kimera_vio_eval
  Update tf to rosbag scripts
  Update write tf rosbags
  Add bash file for writing tfs to rosbags in batch
  Simplify and update add_tfs
  WIP writer of csvs poses to rosbags
  Wrong function name
  Adapt launch file: log gt to csv directly from rosbag if offline (instead of gt_logger)
  Add gt_logging in rosbag parser
  Add script for traj csv gen
  Make gt init in offline + parallel work
  Update RVIZ config for tesse
  Add ros offline + parallel = super fast
  Refactor launch file
  Add missing include file for IDE
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants