Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vocabulary_reference not null constraint on loading vocab using omop_vocab_load script #55

Open
FadyRezkGhattas opened this issue Nov 21, 2018 · 0 comments

Comments

@FadyRezkGhattas
Copy link

FadyRezkGhattas commented Nov 21, 2018

Related to issue in CommonDataModel: OHDSI/CommonDataModel#233

That has been solved in CommonDataModel repository through a 5 day old commit: kids-first/CommonDataModel@b53f696

However, in the tutorial here: https://github.com/MIT-LCP/mimic-omop/blob/master/omop/build-omop/postgresql/README.md we reset the CDM repository to a commit from march missing on the above fix. Therefore, I still get the same null constrained while loading Athena vocab even though fixed in the issue above.

I tried cloning the latest CDM repository and following the tutorial without resetting the code to march but still getting the same output error.

Therefore, what I did was follow the tutorial but after resetting to the march commit, I followed the changes in the bug fix from CDM to edit the relevant files in my local copy and then continued following the tutorial.

That worked fine but not sure if it will cause any problems as I continue doing the ETL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant