Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic-iv/concepts: fix postgres-make-concepts and minor updates #1363

Merged

Commits on Aug 10, 2022

  1. mimic-iv/concepts/convert_bigquery_to_postgres: fix regular expressions

    Currently, `REGEX_DATETIME_DIFF` doesn't match for all occurrences of
    `DATETIME_DIFF` and `postgres-make-concepts.sql` errors out. For example:
    
    ```
    psql:demographics/age.sql:30: ERROR:  column "year" does not exist
    LINE 22: ...mittime, DATETIME(pa.anchor_year, 1, 1, 0, 0, 0), YEAR) + pa..
    ```
    
    Also, `PERL_REGEX_ROUND` doesn't correctly match `ROUND(...)` with
    nested functions, for example with a nested `DATETIME_DIFF`:
    
    ```
    psql:demographics/icustay_detail.sql:33: ERROR:  syntax error at or near "as"
    LINE 17: , ROUND( CAST( DATETIME_DIFF(ie.outtime as numeric),ie.intim...
    ```
    
    Update both regular expressions accordingly.
    schu committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    b6d6b6d View commit details
    Browse the repository at this point in the history
  2. mimic-iv/concepts: fix relation names

    Since 8ed4060 the relation name prefix
    is `mimiciv_`.
    schu committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    f689125 View commit details
    Browse the repository at this point in the history
  3. mimic-iv/concepts/postgres/medication: add remaining files

    The following auto generated files for PostgreSQL were not added to the
    repo yet:
    
    postgres/medication/milrinone.sql
    postgres/medication/norepinephrine_equivalent_dose.sql
    postgres/medication/vasoactive_agent.sql
    schu committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    f9de3b7 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2022

  1. mimic-iv/concepts/postgres/postgres-make-concepts: fix order

    Some concepts have a dependency on others, for example
    `norepinephrine_equivalent_dose.sql` expects
    `mimiciv_derived.vasoactive_agent` to exist.
    
    Fixup for 43a4245
    schu committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    b6b3fb5 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2022

  1. Configuration menu
    Copy the full SHA
    842e1b6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5eb083e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f66606f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7d72fef View commit details
    Browse the repository at this point in the history