-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mimic-iv/concepts: fix postgres-make-concepts
and minor updates
#1363
Merged
alistairewj
merged 8 commits into
MIT-LCP:main
from
schu:schu/fix-mimic-iv-concepts-postgres-setup
Oct 4, 2022
Merged
mimic-iv/concepts: fix postgres-make-concepts
and minor updates
#1363
alistairewj
merged 8 commits into
MIT-LCP:main
from
schu:schu/fix-mimic-iv-concepts-postgres-setup
Oct 4, 2022
Commits on Aug 10, 2022
-
mimic-iv/concepts/convert_bigquery_to_postgres: fix regular expressions
Currently, `REGEX_DATETIME_DIFF` doesn't match for all occurrences of `DATETIME_DIFF` and `postgres-make-concepts.sql` errors out. For example: ``` psql:demographics/age.sql:30: ERROR: column "year" does not exist LINE 22: ...mittime, DATETIME(pa.anchor_year, 1, 1, 0, 0, 0), YEAR) + pa.. ``` Also, `PERL_REGEX_ROUND` doesn't correctly match `ROUND(...)` with nested functions, for example with a nested `DATETIME_DIFF`: ``` psql:demographics/icustay_detail.sql:33: ERROR: syntax error at or near "as" LINE 17: , ROUND( CAST( DATETIME_DIFF(ie.outtime as numeric),ie.intim... ``` Update both regular expressions accordingly.
Configuration menu - View commit details
-
Copy full SHA for b6d6b6d - Browse repository at this point
Copy the full SHA b6d6b6dView commit details -
mimic-iv/concepts: fix relation names
Since 8ed4060 the relation name prefix is `mimiciv_`.
Configuration menu - View commit details
-
Copy full SHA for f689125 - Browse repository at this point
Copy the full SHA f689125View commit details -
mimic-iv/concepts/postgres/medication: add remaining files
The following auto generated files for PostgreSQL were not added to the repo yet: postgres/medication/milrinone.sql postgres/medication/norepinephrine_equivalent_dose.sql postgres/medication/vasoactive_agent.sql
Configuration menu - View commit details
-
Copy full SHA for f9de3b7 - Browse repository at this point
Copy the full SHA f9de3b7View commit details
Commits on Aug 11, 2022
-
mimic-iv/concepts/postgres/postgres-make-concepts: fix order
Some concepts have a dependency on others, for example `norepinephrine_equivalent_dose.sql` expects `mimiciv_derived.vasoactive_agent` to exist. Fixup for 43a4245
Configuration menu - View commit details
-
Copy full SHA for b6b3fb5 - Browse repository at this point
Copy the full SHA b6b3fb5View commit details
Commits on Sep 29, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 842e1b6 - Browse repository at this point
Copy the full SHA 842e1b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5eb083e - Browse repository at this point
Copy the full SHA 5eb083eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f66606f - Browse repository at this point
Copy the full SHA f66606fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d72fef - Browse repository at this point
Copy the full SHA 7d72fefView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.