-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor] make s2p a python package that can be installed with pip #198
Conversation
I think there should be only a few minor conflicts with #196:
|
from s2p import masking | ||
from s2p import triangulation | ||
from s2p import fusion | ||
from s2p import visualisation | ||
|
||
|
||
def pointing_correction(tile, i): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe those functions should not be in init but in a dedicated module in s2p package no ? If we were to write tests for each of them, how would we proceed ?
I just did a merge by hand with #196 and it is fairly easy. There are a few minor conflicts on |
This pull request reorganises the sources in order to make
s2p
installable withpip
. The main changes are:s2p
is now a python package (instead of a python module)s2plib
was renamed tos2p
s2p.py
has disappeared and its content is split amongs2p/__init__.py
(most of the code) ands2p/cli.py
(command line parsing code)s2p
withpip
, a CLI tool nameds2p
becomes available in the system PATHs2p_test.py
was moved totests/test_s2p.py
testdata
was moved totests/data
Python codes that depend on
s2p
should not be affected:import s2p
still works in the same way.Shell scripts running
python /path/to/your/clone/of/s2p/s2p.py
should be updated to run insteads2p
as a standalone command line tool.This pull request contains the changes of pull request #191.
EDIT: A source distribution of
s2p
corresponding to this branch's version is available on PyPI and can be installed withpip
: