-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Furo theme to the documentation build #70
Conversation
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
=======================================
Coverage 90.93% 90.93%
=======================================
Files 14 14
Lines 1235 1235
=======================================
Hits 1123 1123
Misses 112 112
|
Very neat, I like it! Question for @NawalK: Should we switch them/adopt coral instead? Also @mscheltienne, since you were talking changelogs and you're modifying the documentation, can you add the current changelog as an item of the documentation, please? |
Usually, the changelog would be defined per version, e.g. for scipy: https://docs.scipy.org/doc/scipy/release.html |
Sounds fair enough - I am fairly attached to the autorelease system tbh, so I prefer having that (also, we're at a much less complex stage than scipy for our changelog to be fairly small). |
Seems to be working great, and it's easy to follow! |
A couple more points/ideas:
will render with a link to the matplotlib documentation while it will not if
|
Beside the warnings (unless you want to take care of them), yes to all of the above! Also re:logos, could you use the circle_coral ones on both light and dark? |
for more information, see https://pre-commit.ci
@mscheltienne let me know when this PR is ready for review! |
Logo changed, looks better! I added nitpick, numpydoc, sphinx-gallery. It build with about 170 warnings, I brought it down to 65 remaining warnings. I'll let you fix the remaining ones, I was a bit lazy to go through all the files/docstrings ;) It's not very useful, especially above the title. If you are not familiar with some of those extensions, let me know if you have any questions on the configuration; and feel free to push directly to this PR if you need. |
Thank you Mathieu! Can I merge this PR then (I won't fix warnings anyway 😅)? |
fix typo
Yes, I think it's good to merge, but check maybe quickly the documentation render: https://nigsp--70.org.readthedocs.build/en/70/ |
I checked it locally, seems good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes #68
Change Type
bugfix
(+0.0.1)minor
(+0.1.0)major
(+1.0.0)refactoring
(no version update)test
(no version update)infrastructure
(no version update)documentation
(no version update)other
A couple of information: it does build and look OK, but with warnings. The same warnings are present on the
main
branch withsphinx_rtd_theme
anyway, so I guess you did not configure the CI build to fail on warnings. Then a couple of words on what I changed/added beside the theme:Added the light/dark logos (very nice ones!) in SVG format to the
docs/_static/
folder. Personally, I would store all logos there anyway and point to that location where it's needed, e.g. in theREADME.md
. Let me know if you want a different logo version instead of the light/dark I used.Added a couple of extensions: mathjax for mathematical expressions, bibtex for bibliography, copybutton, design and issues. It's a personal default set, let me know if you want to remove some.
bibtex
requires a.bib
file listing the bibliography anyway, so for now it's not active.mathjax
renders mathematical expressions, e.g. :math:\frac{\partial{B_x}}{\partial{x}}
renders as:copybutton
adds a button to copy the content of a code-block, super useful!design
adds a couple of directives for tiles, grids, cards, dropdown, ... https://sphinx-design.readthedocs.io/en/latest/ It's easy to use and looks very nice.issues
adds anissue
andpr
directive to link to GitHub, very useful in a changelog. e.g.Changed the landing page
index
by::hide-toc:
to remove the right-side menu which only containedCite
(only subtitle present)