Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust io.load_nifti_get_mask to expect 4 dimensions in timeseries and 3 in masks by default #48

Merged
merged 1 commit into from
Dec 23, 2022

Conversation

smoia
Copy link
Collaborator

@smoia smoia commented Dec 22, 2022

Closes #

Proposed Changes

Change Type

  • bugfix (+0.0.1)
  • minor (+0.1.0)
  • major (+1.0.0)
  • refactoring (no version update)
  • test (no version update)
  • infrastructure (no version update)
  • documentation (no version update)
  • other

Checklist before review

  • I added everything I wanted to add to this PR.
  • [Code or tests only] I wrote/updated the necessary docstrings.
  • [Code or tests only] I ran and passed tests locally.
  • [Documentation only] I built the docs locally.
  • My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • My code respects the adopted style, especially linting conventions.
  • The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • I added or indicated the right labels.
  • I added information regarding the timeline of completion for this PR.
  • Please, comment on my PR while it's a draft and give me feedback on the development!

@smoia smoia added the Minormod This PR generally closes an `Enhancement` issue. It increments the minor version (0.+1.0) label Dec 22, 2022
@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Merging #48 (8acd923) into master (6fd3cb1) will decrease coverage by 0.06%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
- Coverage   91.40%   91.33%   -0.07%     
==========================================
  Files          14       14              
  Lines        1210     1212       +2     
==========================================
+ Hits         1106     1107       +1     
- Misses        104      105       +1     
Impacted Files Coverage Δ
nigsp/io.py 90.64% <50.00%> (-0.49%) ⬇️

@smoia smoia merged commit cae1cad into MIPLabCH:master Dec 23, 2022
@smoia smoia deleted the fix/loadnifti branch December 23, 2022 08:50
@smoia
Copy link
Collaborator Author

smoia commented Dec 23, 2022

🚀 PR was released in 0.15.0 🚀

@smoia smoia added the Released This PR has been released! label Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minormod This PR generally closes an `Enhancement` issue. It increments the minor version (0.+1.0) Released This PR has been released!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant