Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility (1) to specify which diagonal to use for matrices symmetric normalisation and (2) to avoid "0" elements in the diagonal #29

Merged
merged 4 commits into from
Oct 10, 2022

Conversation

smoia
Copy link
Collaborator

@smoia smoia commented Oct 7, 2022

Closes #

Proposed Changes

Change Type

  • bugfix (+0.0.1)
  • minor (+0.1.0)
  • major (+1.0.0)
  • refactoring (no version update)
  • test (no version update)
  • infrastructure (no version update)
  • documentation (no version update)
  • other

Checklist before review

  • I added everything I wanted to add to this PR.
  • [Code or tests only] I wrote/updated the necessary docstrings.
  • [Code or tests only] I ran and passed tests locally.
  • [Documentation only] I built the docs locally.
  • My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • My code respects the adopted style, especially linting conventions.
  • The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • I added or indicated the right labels.
  • I added information regarding the timeline of completion for this PR.
  • Please, comment on my PR while it's a draft and give me feedback on the development!

@smoia smoia added the Minormod This PR generally closes an `Enhancement` issue. It increments the minor version (0.+1.0) label Oct 7, 2022
@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Merging #29 (db5c276) into master (d990f48) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   90.50%   90.61%   +0.11%     
==========================================
  Files          14       14              
  Lines        1053     1066      +13     
==========================================
+ Hits          953      966      +13     
  Misses        100      100              
Impacted Files Coverage Δ
nigsp/operations/laplacian.py 100.00% <100.00%> (ø)

@smoia smoia merged commit 29d3681 into MIPLabCH:master Oct 10, 2022
@smoia smoia added the Released This PR has been released! label Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minormod This PR generally closes an `Enhancement` issue. It increments the minor version (0.+1.0) Released This PR has been released!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant