WDRT parity - continued #147
Conversation
|
I wont be able to get to the remaining items in Issue #146 and some of them require compatibility with higher version of MHKiT-Python anyways so we'll have to leave that one open. Also, see my comment on Issue #109 and why I think that one should be closed as well. Otherwise this should be ready for review. |
| options.max_x1 = py.None; | ||
| options.max_x2 = py.None; | ||
| options.PCA = py.None; | ||
| options.PCA_bin_size = 250; |
There was a problem hiding this comment.
I think this is a valid strategy to set these values but we will need to ensure that these don't diverge from the default values set in MHKiT-Python
There was a problem hiding this comment.
@hivanov-nrel this looks good to me, nice work!
I added one note about setting default values in MATLAB vs Python. I'm not sure what is a good long term strategy for this type of default setting, but it would be ideal to use the default values in MHKiT-Python. In this situation I don't think there is much of a choice without refactoring a significant portion of the MHKiT-Python environmental contours code. Your solution here works and keeps us moving forward.
|
@hivanov-nrel, I will fix the merge conflict shortly and then I think we can merge this safely... |
code:
examples: