Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select genes options #68

Open
kosankem opened this issue May 25, 2021 · 4 comments
Open

Select genes options #68

kosankem opened this issue May 25, 2021 · 4 comments

Comments

@kosankem
Copy link

kosankem commented May 25, 2021

It is possible to select genes manually and simultanously via list. The manually selected genes, however, are the only ones that are than displayed in the end. It would be more intuitive if the selecetion of one of the selection methods would clear the fields of the other methods as it is not possible to use them thogether.

Amendment:
After some more trying, I noticed that what I described above is actually the case. However, I was able to miss that I need to press the select list button. I can imagine that the same might happen to others as well. Is it possible to chose simply via the pull down menu. That would be more intuitive as for the two other selection methods one does not need to press an extra button.

@kosankem
Copy link
Author

Should we include a limit of gene input to avoid too extensive processing time?

@kosankem
Copy link
Author

In case that no gene could be extracted from the uploaded excel file, a warning might be helpful.

@mariusrueve
Copy link
Contributor

mariusrueve commented Jun 13, 2021

I added a warning when the excel file is empty (2b80250).

The "Select List" is a workaround and made the implementation of this feature a lot easier. In order to archive the goal with a simple drow down menu, I have to restructure the code. I will try to fix this, because, as you have said, it is way more intuitive.

What do you think is a reasonable limit for the gene selection? I can't estimate how many genes are enough

@kosankem
Copy link
Author

I have the impression that the numbers of genes that are displayed in heatmaps are often 50, 100, 300, or 500. So, maybe 500 might be a reasonable limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants