Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin scipy #106

Closed
tsmathis opened this issue Jul 3, 2024 · 4 comments
Closed

Unpin scipy #106

tsmathis opened this issue Jul 3, 2024 · 4 comments

Comments

@tsmathis
Copy link

tsmathis commented Jul 3, 2024

Scipy is currently pinned at 1.12.0 which is causing some difficulty updating dependencies in down stream packages (emmet-core #1020)

Is 1.12.0 specifically needed here? Is a >= option viable?
@hmacdope
Copy link
Member

hmacdope commented Jul 3, 2024

@orionarcher can you remember why this pin exists again?

@hmacdope hmacdope mentioned this issue Jul 3, 2024
Merged
1 task
@tsmathis
Copy link
Author

Just checking in again on this, looks like the pin was successfully removed? Would it be possible to mint a new release?

@tsmathis tsmathis mentioned this issue Jul 18, 2024
Closed
@orionarcher
Copy link
Collaborator

Thank you to hmacdope and richard for fixing the issue. I can mint a new release soon.

@tsmathis
Copy link
Author

thanks orion :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hmacdope @orionarcher @tsmathis