Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fmt] transformations #4809

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

RMeli
Copy link
Member

@RMeli RMeli commented Nov 27, 2024

Format MDAnalysis/transformations and MDAnalysisTests/transformations.

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4809.org.readthedocs.build/en/4809/

@RMeli RMeli self-assigned this Nov 27, 2024
@pep8speaks
Copy link

pep8speaks commented Nov 27, 2024

Hello @RMeli! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 101:80: E501 line too long (83 > 79 characters)
Line 106:80: E501 line too long (88 > 79 characters)
Line 114:80: E501 line too long (88 > 79 characters)

Comment last updated at 2024-11-28 13:36:26 UTC

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 96.49123% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.66%. Comparing base (441e2c6) to head (19a907f).

Files with missing lines Patch % Lines
package/MDAnalysis/transformations/translate.py 85.71% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4809      +/-   ##
===========================================
- Coverage    93.68%   93.66%   -0.03%     
===========================================
  Files          177      189      +12     
  Lines        21742    22808    +1066     
  Branches      3055     3055              
===========================================
+ Hits         20369    21362     +993     
- Misses         927     1000      +73     
  Partials       446      446              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@marinegor marinegor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the .git-ignore-blame-revs file update, which I recall you're doing at the end anyway

ref_matrix = np.asarray([[-1, 0, 0],
[0, -1, 0],
[0, 0, 1]], np.float64)
ref_matrix = np.asarray([[-1, 0, 0], [0, -1, 0], [0, 0, 1]], np.float64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ref_matrix = np.asarray([[-1, 0, 0], [0, -1, 0], [0, 0, 1]], np.float64)
ref_matrix = np.asarray([[-1, 0, 0], [0, -1, 0], [0, 0, 1],], np.float64)

@RMeli
Copy link
Member Author

RMeli commented Nov 29, 2024

which I recall you're doing at the end anyway

Thanks @marinegor for the review! Yes, I'll update the file in a separate PR, pooling some of the [fmt] PRs, the reason being that cleaning up history to only have two commits is just too tedious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants