-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fmt] transformations #4809
base: develop
Are you sure you want to change the base?
[fmt] transformations #4809
Conversation
Hello @RMeli! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-11-28 13:36:26 UTC |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4809 +/- ##
===========================================
- Coverage 93.68% 93.66% -0.03%
===========================================
Files 177 189 +12
Lines 21742 22808 +1066
Branches 3055 3055
===========================================
+ Hits 20369 21362 +993
- Misses 927 1000 +73
Partials 446 446 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for the .git-ignore-blame-revs
file update, which I recall you're doing at the end anyway
ref_matrix = np.asarray([[-1, 0, 0], | ||
[0, -1, 0], | ||
[0, 0, 1]], np.float64) | ||
ref_matrix = np.asarray([[-1, 0, 0], [0, -1, 0], [0, 0, 1]], np.float64) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ref_matrix = np.asarray([[-1, 0, 0], [0, -1, 0], [0, 0, 1]], np.float64) | |
ref_matrix = np.asarray([[-1, 0, 0], [0, -1, 0], [0, 0, 1],], np.float64) |
Thanks @marinegor for the review! Yes, I'll update the file in a separate PR, pooling some of the |
Format
MDAnalysis/transformations
andMDAnalysisTests/transformations
.Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4809.org.readthedocs.build/en/4809/