Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExtensibleChoiceParameterDefinition support request #301

Closed
Denis-Alexeev opened this issue Jul 14, 2021 · 15 comments · Fixed by #304
Closed

ExtensibleChoiceParameterDefinition support request #301

Denis-Alexeev opened this issue Jul 14, 2021 · 15 comments · Fixed by #304

Comments

@Denis-Alexeev
Copy link

Could you please support ExtensibleChoiceParameterDefinition?
image

@MCMicS
Copy link
Owner

MCMicS commented Jul 14, 2021

Und i check the api if all needed values are delivered

@MCMicS
Copy link
Owner

MCMicS commented Jul 14, 2021

Do you use this plugin: https://plugins.jenkins.io/extensible-choice-parameter/

if yes I cheked the API a time ago and the API was not delivered all needed values. This Year I looked again and for textarea based it seems to work
Tests also "System Grrovy Choice Parameter"

Editable will not work via API. Is this OK for your purpose?

WIll add this the days and give you an eap version for this

see also #159

@MCMicS
Copy link
Owner

MCMicS commented Jul 15, 2021

There is another API Bug
From View I cannot receive the Choices. So I had to workaround with a extra call to get the needed values or I offer an textfield if no choices are available
jenkins-control-plugin-0.13.12-2021.2-eap5.zip

Issue in Jenkins: https://issues.jenkins.io/browse/JENKINS-66145

@Denis-Alexeev
Copy link
Author

Denis-Alexeev commented Jul 15, 2021

jenkins-control-plugin-0.13.12-2021.2-eap5.zip

Unfortunately, it is not compatible with my pycharm version. Albeit I have the newest professional edition installed (mac os).
image

@MCMicS
Copy link
Owner

MCMicS commented Jul 15, 2021

Yes it a eap for 2021.2
I can create an version for you later the day

But I'm still work on a solution to get the choices ist correctly

@MCMicS
Copy link
Owner

MCMicS commented Jul 15, 2021

HEre is an version for previous version. Still without Choices. It renders as a text input field currently

jenkins-control-plugin-0.13.12-2021.2-eap5-pycharm.zip

@MCMicS
Copy link
Owner

MCMicS commented Jul 15, 2021

if you use following snapshot (build by myself) it will work but I don't know if and when this will be merged

rename from '.zip' to '.hpi' and install via jenkins

extensible-choice-parameter-1.7.1-SNAPSHOT_MCMicS.zip

@Denis-Alexeev
Copy link
Author

HEre is an version for previous version. Still without Choices. It renders as a text input field currently

jenkins-control-plugin-0.13.12-2021.2-eap5-pycharm.zip

Yes. It works and renders just as a text field. It is enough for me for now, because that field suggests choice of version, and by default the newest one.

if you use following snapshot (build by myself) it will work but I don't know if and when this will be merged

rename from '.zip' to '.hpi' and install via jenkins

extensible-choice-parameter-1.7.1-SNAPSHOT_MCMicS.zip

Unfortunately, I can't. That is not my personal Jenkins instance. I work for a company which uses Jenkins. And I'm not an administrator))

Thank you for your help! You are awesome =)

@MCMicS
Copy link
Owner

MCMicS commented Jul 16, 2021

@Denis-Alexeev Thanks for feedback.
I will released it for all products with real build in next weeks.

@Denis-Alexeev
Copy link
Author

When I open pycharm I get the error. But after closing the error window plugin works without problems. Should I open new issue for that?
image

@MCMicS
Copy link
Owner

MCMicS commented Jul 16, 2021

Strange that there is an nullpointer 😄
Maybe an timing problem because it xould only happen if no JEnkins settings ar found (which is unlikely) and the current view is reset to empty during method call

But please report if this occurs every start. Is it occuring only with my last build or also with previous versions?

I will backport alkll changes to older IDEA Versions today or at weekend and then I will build a new build. MAybe something is broken with my latest build :)

I've tested it with my PyCharm it no error occured but I will add an better check for null.
Do you have an View with many jobs? Do you use an favorite view or all or simple view

@Denis-Alexeev
Copy link
Author

Denis-Alexeev commented Jul 16, 2021

  • It occurs every time I start pycharm
  • It occurs only with last build provided here
  • I use predefined by admin views. There are a lot of views and they contain a lot of jobs.

Is there any option 'not to download log' when I start any job via pycharm? Because it starts to daownload log. And I can't prevent or kill that downloading task. I'm forced to restsrt IDE.

@MCMicS
Copy link
Owner

MCMicS commented Jul 16, 2021

It occurs only with last build provided here

OK Maybe something get wrong with the build.

Is there any option 'not to download log' when I start any job via pycharm?

no such an option not exists yet. But you can try to use BUild Delay. If the delay is larger that 1 second it should not load the log
please open an feature request for it. or the possibility to cancel download logs
is the log a long running job or why you have to restart IDE

@MCMicS
Copy link
Owner

MCMicS commented Jul 16, 2021

@Denis-Alexeev I have add an option to prevent load log on trigger build
grafik

@MCMicS
Copy link
Owner

MCMicS commented Jul 27, 2021

released with 0.13.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants