Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error overlay over whole of screen if connection is lost #233

Closed
HonoluluHenk opened this issue Jul 10, 2020 · 6 comments · Fixed by #236
Closed

Error overlay over whole of screen if connection is lost #233

HonoluluHenk opened this issue Jul 10, 2020 · 6 comments · Fixed by #236
Milestone

Comments

@HonoluluHenk
Copy link

I'm working on a corporate VPN.
Initially, everything works fine.

When the VPN disconnects, an error bubble is presented repeatedly over the full width of the screen, telling me that an IOExcpetion happened, blocking my view of the code.

Steps to reproduce:

  1. Setup the jenkins plugin with a jenkins job and refresh once
  2. Unplug the network cable :)
  3. Refresh again

Content of the error bubble:
IO Error during method execution 'https://somewhere.og/job/myjob//api/json?tree=name,url,jobs%5Bname,fullName,displayName,fullDisplayName,jobs,url,color,buildable,inQueue,healthReport%5Bdescription,iconUrl%5D,lastBuild%5Bid,url,building,result,number,displayName,fullDisplayName,timestamp,duration%5D,property%5BparameterDefinitions%5Bname,type,defaultParameterValue%5Bvalue%5D,description,choices%5D%5D%5D': Connection reset

This message should - if at all visible - imho be placed in the "Event Log" (typically this is located at the lower right).

Would be even nicer to have a user-friendly message in the plugins' toolbar-view telling me that the connection currently is unavailable.

@MCMicS MCMicS added this to the 0.13.7 milestone Jul 10, 2020
@MCMicS
Copy link
Owner

MCMicS commented Jul 11, 2020

related to #144

@MCMicS
Copy link
Owner

MCMicS commented Jul 11, 2020

I changed the message and the notification to be confugurable. Default is Tool Window Balloon (as previous). If the message is too large for screen it is not shown. It is also possible to configure it (Settings -> Appearance -> Notifications -> Jenkins Notifications) to show only balloon or only log

Could you please give it it try and send feedback.
jenkins-control-plugin-0.13.7-2020.1-eap2.zip

MCMicS added a commit that referenced this issue Jul 12, 2020
Add Notification group to configure appearance
@MCMicS
Copy link
Owner

MCMicS commented Jul 14, 2020

@HonoluluHenk Could you please give it it try and send feedback.

@HonoluluHenk
Copy link
Author

Nice, works for me, thanks!

Imho, this needs some documenting on the plugins homepage - or the overview page in the IntelliJ installed plugins view.
The reason being that not that many plugins implement notification configuration in such a nice way and this settings-area is possibly not that well known.

@MCMicS
Copy link
Owner

MCMicS commented Jul 14, 2020

thanks for feedback. The documentation will be updated on release. This will describe how to change the notification settings

@MCMicS MCMicS mentioned this issue Jul 19, 2020
@MCMicS
Copy link
Owner

MCMicS commented Jul 28, 2020

released with 0.13.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants