Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding an "error checking" mode to opt-in to expensive checks of expected data attributes #95

Open
2 tasks
vijayiyer05 opened this issue Apr 13, 2021 · 2 comments

Comments

@vijayiyer05
Copy link
Collaborator

vijayiyer05 commented Apr 13, 2021

Updated issue from original question below.

Two cases have emerged to date for possible error checking:

  • Rebuilding spike_times from raw data (API provides raw data, so the preprocessed spike times could be verified)
  • Confirming the various fluorescence timebases are equivalent as expected (each fluorescence trace has its own value in API)

Idea of creating a mode would be to keep avoiding doing calculations for expected redundant values generally, but to keep the code/capability allowing checks of the other API/file pathway for equality.

The build_spike_times() method is currently commented out and appears to be a no-op when re-inserted. Not sure what its initial intent was -- does it have an effect for some use cases?

@DylanMuir
Copy link
Collaborator

DylanMuir commented Apr 13, 2021 via email

@vijayiyer05
Copy link
Collaborator Author

Thanks @DylanMuir for the context. It seems like this could be considered in the context of an "error checking" mode. Updating issue to capture this broader context.

@vijayiyer05 vijayiyer05 changed the title Review spikeTimes property logic Consider adding an "error checking" mode where the API or files provides multiple pathways to what should be the same information Apr 13, 2021
@vijayiyer05 vijayiyer05 changed the title Consider adding an "error checking" mode where the API or files provides multiple pathways to what should be the same information Consider adding an "error checking" mode to opt-in to expensive checks of expected data attributes Jun 2, 2021
@DylanMuir DylanMuir added this to the SOW_M3 milestone Jul 5, 2021
@vijayiyer05 vijayiyer05 modified the milestones: SOW_M3, SOW_M2 Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants