You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The public access for the info and id properties seems like a code smell.
A couple of ideas:
Making this a "MetricsItem" class than inherits from Item. Currently there isn't a class that would inherit from both LinkedFilesItem and MetricsItem, so there isn't strictly a need for a mixin (i.e. multiple inheritance)
Using an access control list to specify which mixin(s) have access, if a good way can be identified to combine children & specified mixins.
Combining 1&2 to create a MixinItem abstract class of which LinkedFilesItem and MetricsItem would be subclasses; and then Item would give access just to MixinItem
The public access for the
info
andid
properties seems like a code smell.A couple of ideas:
Item
. Currently there isn't a class that would inherit from bothLinkedFilesItem
andMetricsItem
, so there isn't strictly a need for a mixin (i.e. multiple inheritance)MixinItem
abstract class of whichLinkedFilesItem
andMetricsItem
would be subclasses; and then Item would give access just toMixinItem
Based on original post by @vijayiyer05 in #62 (comment)
The text was updated successfully, but these errors were encountered: