Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor MetricsItem #135

Open
vijayiyer05 opened this issue Oct 3, 2021 · 0 comments
Open

Refactor MetricsItem #135

vijayiyer05 opened this issue Oct 3, 2021 · 0 comments

Comments

@vijayiyer05
Copy link
Collaborator

The public access for the info and id properties seems like a code smell.

A couple of ideas:

  1. Making this a "MetricsItem" class than inherits from Item. Currently there isn't a class that would inherit from both LinkedFilesItem and MetricsItem, so there isn't strictly a need for a mixin (i.e. multiple inheritance)
  2. Using an access control list to specify which mixin(s) have access, if a good way can be identified to combine children & specified mixins.
  3. Combining 1&2 to create a MixinItem abstract class of which LinkedFilesItem and MetricsItem would be subclasses; and then Item would give access just to MixinItem

Based on original post by @vijayiyer05 in #62 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant