Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add password unlocking middleware #2761

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Nov 28, 2024

As requested in #2339

If a ?password= is added when sharing the url of an album e.g.:
https://lychee.test/gallery/somealbum?password=test then Lychee will be try to use the password (here test) to unlock the album.
If the password is wrong, this fails silently.

If a password is provided but the setting is set to false in the database a warning will be raised in the logs.

@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Nov 28, 2024
@ildyria ildyria requested a review from d7415 November 28, 2024 17:53
@ildyria ildyria added this to the 6.1.3 milestone Nov 28, 2024
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 84.58%. Comparing base (f77198f) to head (05441f2).
Report is 2 commits behind head on master.

Additional details and impacted files

@ildyria ildyria merged commit 1d7fbf7 into master Nov 28, 2024
51 checks passed
@ildyria ildyria deleted the add-password-unlock-middleware branch November 28, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants