Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch Float16 tests to BFloat16 #1009

Open
avik-pal opened this issue Jul 29, 2024 · 2 comments
Open

Switch Float16 tests to BFloat16 #1009

avik-pal opened this issue Jul 29, 2024 · 2 comments
Labels
luxlib reactant

Comments

@avik-pal
Copy link
Member

That is the standard for machine learning and we might as well test for it, rather than Float16 which are quite flaky
@avik-pal avik-pal added the good first issue Good for newcomers label Jul 29, 2024
@avik-pal avik-pal mentioned this issue Jul 29, 2024
Open
8 tasks
@avik-pal avik-pal removed the good first issue Good for newcomers label Aug 3, 2024
@avik-pal
Copy link
Member Author

avik-pal commented Aug 3, 2024

Not a good first issue, see the linked PR for more details.

@avik-pal avik-pal transferred this issue from LuxDL/LuxLib.jl Nov 3, 2024
@avik-pal avik-pal added the luxlib label Nov 3, 2024
@avik-pal
Copy link
Member Author

We will probably never have widespread support for native julia ops in BFloat16 (at least on the Lux end), instead we should be adding more reactant tests for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
luxlib reactant
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@avik-pal