Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to new H5P core #1312

Closed
sr258 opened this issue Apr 16, 2021 · 2 comments · Fixed by #1366
Closed

Update to new H5P core #1312

sr258 opened this issue Apr 16, 2021 · 2 comments · Fixed by #1366

Comments

@sr258
Copy link
Member

sr258 commented Apr 16, 2021

It looks like the new PHP core is reaching some level of stability: the production endpoints were added to the PHP code. We could start checking out what we need to do to remain compatible.
@sr258
Copy link
Member Author

sr258 commented May 1, 2021

Compare of h5p PHP editor: h5p/h5p-editor-php-library@9361892...7bc1927

Compare of the h5p core: h5p/h5p-php-library@55b0401...588f096

@sr258
Copy link
Member Author

sr258 commented May 1, 2021

A first check showed that the changes look bigger than they are: the core is mostly unchanged and nearly all changes relate to the integration of the content hub.

@sr258 sr258 mentioned this issue May 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(h5p-server): core update Lumieducation/H5P-Nodejs-library
1 participant
@sr258