-
Notifications
You must be signed in to change notification settings - Fork 30
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Showing
1 changed file
with
8 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d6ac84f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment is outdated now, it should say something about not holding the lock while the test is running. I am never 100% sure about when temporaries get dropped but empirically this version seems to work. I tested this commit in a workspace of mine with more tests than threads, all of them ran and it used multiple threads as expected. I also don't see any other problems at a glance.