Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also merge event descriptions #1

Open
dingcycle opened this issue Sep 15, 2023 · 1 comment
Open

Also merge event descriptions #1

dingcycle opened this issue Sep 15, 2023 · 1 comment

Comments

@dingcycle
Copy link

dingcycle commented Sep 15, 2023

Thanks for your work @LukasForst, it gave me nice inspiration and I'm using it for a personal project. :)
It seemed quite obvious me to the DESCRIPTION of events should be included as well in the merged calendar.

Yet I soon realized it wasn't the case in camerge (yet).

I assume that this is the place where the field filtering happens.
Was there any reason why the DESCRIPTION was not included?

@LukasForst
Copy link
Owner

hi! I think the answer to this question is the line above the one you linked 😄:

# TODO: maybe investigate what is really needed and what is not

feel free to submit PR! I wanted to work more on this project a bit more, but sadly I don't have enough time right now.

One thing to think of when implementing it - when anonymisation is enabled with busy_place_holder=True, one should probably anonymise the description as well (so not set it or not copy it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants