Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to IE11 #9

Merged
merged 1 commit into from
May 5, 2020
Merged

Add support to IE11 #9

merged 1 commit into from
May 5, 2020

Conversation

Borrajo
Copy link

@Borrajo Borrajo commented Apr 28, 2020

in ie11 the tooltip did not follow the cursor. with this modification it is solved.

  • The pull request is complete according to the Definition of Done
    • Acceptance criteria in the ticket have been met
    • Automated tests are written according to the test plan
    • The documentation is up-to-date
    • Deployment automation includes newly introduced environment variables and credentials are added to the credentials.fact file of all servers
  • The pull request has a descriptive title that describes what has changed, and provides enough context for the changelog
  • When applicable, the pull request title starts with the issue number

in ie11 the tooltip did not follow the cursor. with this modification it is solved.
@lukbukkit lukbukkit self-assigned this May 3, 2020
@lukbukkit lukbukkit added the bug Something isn't working label May 3, 2020
@lukbukkit
Copy link
Owner

Thanks a lot for your pull request. Did you test your changes also in other browsers?

@Borrajo
Copy link
Author

Borrajo commented May 3, 2020

Thanks a lot for your pull request. Did you test your changes also in other browsers?

Tested in :

  • Google Chrome
  • Mozilla Firefox
  • Internet Explorer 11
  • Microsoft Edge

Not tested in:

  • Safari.

Documentation:
https://developer.mozilla.org/en-US/docs/Web/API/Window/pageXOffset

https://developer.mozilla.org/en-US/docs/Web/API/Window/scrollX

Copy link
Owner

@lukbukkit lukbukkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to your linked MDN article this change should be fine and increase browser compatibility.

The pageXOffset property is an alias for the scrollX property:

@lukbukkit lukbukkit merged commit 6de0d43 into lukbukkit:master May 5, 2020
@lukbukkit
Copy link
Owner

Thanks for your contribution. The latest version 0.1.3 is now up on npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants