Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parameters needed for MyBooks.Get<Status> #19

Open
bradyguyc opened this issue Sep 18, 2024 · 1 comment
Open

parameters needed for MyBooks.Get<Status> #19

bradyguyc opened this issue Sep 18, 2024 · 1 comment

Comments

@bradyguyc
Copy link

The MyBooks set of api's appear to only return the first 100 entries with no apparent way of retrieving the subsequent items or increasing the limit.

In my branch, I added parameters to these api calls so I could increase the limit. At some point I will look into the ability to retrieve the 2nd page etc... of results, ie see if the openlibrary.org api supports that.

I can now call the api's like below by adding in support for parameters on those api's.

await pipeline.ExecuteAsync(async token => { currentlyReading = await OLClient.MyBooks.GetCurrentlyReadingAsync(OLClient.Username, new KeyValuePair<string, string>("limit", "500")); }, ct);

await pipeline.ExecuteAsync(async token => { alreadyRead = await OLClient.MyBooks.GetAlreadyReadAsync(OLClient.Username, new KeyValuePair<string, string>("limit", "500")); }, ct);
await pipeline.ExecuteAsync(async token => { wantToRead = await OLClient.MyBooks.GetWantToReadAsync(OLClient.Username, new KeyValuePair<string, string>("limit", "500")); }, ct);

@Luca3317
Copy link
Owner

That sounds right - feel free to open a pull request with your changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants