Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend music getInfo to allow MusicResponsiveListItem and Nav Endpoints #751

Merged
merged 5 commits into from
Sep 19, 2024

Conversation

Duell10111
Copy link
Contributor

To allow playlist endpoints of MusicReponsiveListItems used as well for youtube.music.getInfo.

As alternative we maybe could allow generally NavEndpoints as parameter for music.getInfo calls. :)

@Duell10111
Copy link
Contributor Author

Created a alternative branch: https://github.com/Duell10111/YouTube.js/tree/music-info-extend-params, that also allows generic NavEndpoints for the youtube music getInfo function

@LuanRT
Copy link
Owner

LuanRT commented Sep 16, 2024

Nice. Great work!
Feel free to add support for nav endpoints as well. It makes sense since Innertube#getInfo also accepts them.

@Duell10111 Duell10111 changed the title feat: extend music getInfo to allow MusicResponsiveListItem nav endpoints feat: extend music getInfo to allow MusicResponsiveListItem and Nav Endpoints Sep 17, 2024
@Duell10111
Copy link
Contributor Author

Added nav endpoints to getInfo. :)

I am further trying to add the possibility for getting a continuation to the Music upNext tab, but that will be a other PR. :)

@LuanRT LuanRT merged commit 5db449c into LuanRT:main Sep 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants