fix(Search): Fix it occasionally returning only a small number of results #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YouTube seems to have two types of search responses, one of them consists of a single
ItemSectionand then the continuation, the second type is made up of lots ofItemSections each with only a few number of items in them and then the continuation. To be able to handle both cases, I've changed the code to merge together the items from all of the sections. This shouldn't cause any problems, as thePeople also watchedandPeople also search forsub-sections are shelves (Shelfclass) inside of theItemSections.FreeTubeApp/FreeTube#5510