Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log the data:RawNode objects passed to different nodes when parse errors happen #687

Closed
4 tasks done
iBicha opened this issue Jul 11, 2024 · 0 comments · Fixed by #691
Closed
4 tasks done

Log the data:RawNode objects passed to different nodes when parse errors happen #687

iBicha opened this issue Jul 11, 2024 · 0 comments · Fixed by #691
Labels
enhancement New feature or request

Comments

@iBicha
Copy link
Contributor

iBicha commented Jul 11, 2024 •
edited
Loading

Describe your suggestion

When InnertubeError: Something went wrong at <NODE> usually the stack trace is a good indicator of what broke, but having the data:RawNode we're trying to parse can really clarify why it happened.
I think this is super important because the data is not only "setup" specific, but also is country specific, user specific, is A/B tested and so on. Sometimes it is impossible to know what data someone is getting, and why the parser is failing for them but not you.

Other details

No response

Checklist

  • I am running the latest version.
  • I checked the documentation and found no answer.
  • I have searched the existing issues and made sure this is not a duplicate.
  • I have provided sufficient information.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(parser): add classdata to unhandled parse errors
1 participant
@iBicha